Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduction of measurement #160

Merged
merged 6 commits into from
Sep 7, 2023
Merged

introduction of measurement #160

merged 6 commits into from
Sep 7, 2023

Conversation

Afronut
Copy link
Contributor

@Afronut Afronut commented Sep 4, 2023

replace power meter with measurement to allow sending SOC, temperature values to CS

Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Coovy, this looks nice. In your changes the implementation of to_json, from_json and operator<< for StateOfCharge, Temperature, RPM and Measurement is missing in common/types.cpp. Could you add that to this PR?

caller and others added 3 commits September 6, 2023 20:57
P3 want to have their product but not their compnay name in this

Signed-off-by: caller <2248448+caller@users.noreply.github.com>
Signed-off-by: Coovi Meha <mehafelix@gmail.com>
Signed-off-by: coovi meha <mehafelix@gmail.com>
Signed-off-by: Coovi Meha <mehafelix@gmail.com>
Signed-off-by: coovi meha <mehafelix@gmail.com>
Signed-off-by: Coovi Meha <mehafelix@gmail.com>
Signed-off-by: Coovi Meha <mehafelix@gmail.com>
Signed-off-by: Coovi Meha <mehafelix@gmail.com>
@Afronut
Copy link
Contributor Author

Afronut commented Sep 7, 2023

Added the update please review

@Pietfried Pietfried self-requested a review September 7, 2023 14:15
@Pietfried Pietfried merged commit 8a3aa82 into EVerest:main Sep 7, 2023
2 of 3 checks passed
bWF0dGhpYXMK pushed a commit to bWF0dGhpYXMK/libocpp that referenced this pull request Sep 27, 2023
* added measurand support for soc, temp and rpm in OCPP1.6

Signed-off-by: coovi meha <mehafelix@gmail.com>
Signed-off-by: Coovi Meha <mehafelix@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants