B04 offline idle behaviour #168

SNSubramanya · 2023-09-08T14:04:02Z

Offline Behavior Idle Charging Station

B04.FR.01
B04.FR.02

marcemmers · 2023-09-11T07:04:18Z

lib/ocpp/v201/charge_point.cpp

+                    if (!(conn_state_per_evse[{evse_id,connector_id}].connector_status ==
+                          evse->get_state(connector_id))) {
+                        // if the state varied when offline
+                        conn_state_per_evse[{evse_id,connector_id}].is_status_changed_when_offline = true;


Why do we need to store this value for use later instead of using it directly?

I choose this approach as the status notification cannot be sent until the registration status is accepted (see message_callback). So I first check for the change in status in the connection callback and make note of the change in status if it had changed when offline. The registration can take a while and it's possible that the connector state might have changed again.

What about just checking the registration status in the connection callback? When we are accepted we stay accepted even after a lost connection. If we were not accepted yet we can just drop the changes since we are required to send the status notifications of all connectors anyway after a BootNotificationResponse with accepted (B01.FR.05).

marcemmers · 2023-09-11T07:06:07Z

lib/ocpp/v201/charge_point.cpp

+                    conn_states_per_evse_id_key conn_states_struct_key;
+                    conn_states_per_evse_id_value conn_states_struct_value;
+                    EVLOG_debug<< "LIBOCPP: evseId: " << evse_id << " numConn: " << number_of_connectors;
+                    for (int connector_id = 1; connector_id <= number_of_connectors; connector_id++) {


I don't like the fact that you need to iterate the connectors here manually. I know this is currently the only option, but maybe we can improve this by adding a getter function for the entire connector map of an Evse?

marcemmers · 2023-09-11T07:09:05Z

lib/ocpp/v201/charge_point.cpp


+                this->offline_threshold_timer.interval(


I still think it is a cleaner solution to just store the timestamp here and compare it when going back online. Now we have a bool variable and an entire timer object stored and the functionality is just the same.

std::chrono::time_point<std::chrono::steady_clock> should do the trick. It is a monotonic timer so no worries about it moving backwards or whatever.

marcemmers · 2023-09-11T07:10:16Z

lib/ocpp/v201/charge_point.cpp

+                    if (!(conn_state_per_evse[{evse_id,connector_id}].connector_status ==
+                          evse->get_state(connector_id))) {


Suggested change

if (!(conn_state_per_evse[{evse_id,connector_id}].connector_status ==

evse->get_state(connector_id))) {

if (conn_state_per_evse[{evse_id,connector_id}].connector_status !=

evse->get_state(connector_id)) {

marcemmers · 2023-09-12T12:41:56Z

lib/ocpp/v201/charge_point.cpp

+
+            // B04.FR.01
+            // If offline period exceeds offline threshold then send the status notification for all connectors
+            if (is_offline_threshold_expired) {


What about?

Suggested change

if (is_offline_threshold_expired) {

auto offline_duration = std::chrono::steady_clock::now() - time_disconnected;

if (offline_duration >= offline_threshold_value) {

Then you don't need is_offline_threshold_expired anymore and you could also use the threshold value directly without storing anything?

Edit: You don't need the abs since it is a monotonic timer. It will always only increase so it can never be the other way around

marcemmers · 2023-09-12T12:42:23Z

lib/ocpp/v201/charge_point.cpp

@@ -450,7 +505,7 @@ void ChargePoint::init_websocket() {
        });

    this->websocket->register_message_callback([this](const std::string& message) { this->message_callback(message); });
-}
+        }


Please revert this ;)

marcemmers · 2023-09-15T07:57:28Z

include/ocpp/v201/charge_point.hpp

@@ -126,6 +126,26 @@ class ChargePoint : ocpp::ChargingStationBase {
    int network_configuration_priority;
    bool disable_automatic_websocket_reconnects;

+    // store the connector status
+    struct conn_states_per_evse_id_key {


This name seems a bit specific to what it is. Maybe evse_connector_pair or unique_connector or something? That way it can be used for other purposes too.

marcemmers · 2023-09-15T07:57:47Z

include/ocpp/v201/charge_point.hpp

+
+    std::map<conn_states_per_evse_id_key, ConnectorStatusEnum> conn_state_per_evse;
+
+    std::chrono::seconds offline_threshold_value;


This is no longer user right?

which one? they're both used

marcemmers · 2023-09-15T07:58:37Z

lib/ocpp/v201/charge_point.cpp

@@ -425,29 +425,78 @@ void ChargePoint::init_websocket() {

    this->websocket = std::make_unique<Websocket>(connection_options, this->pki_handler, this->logging);
    this->websocket->register_connected_callback([this](const int security_profile) {
+        // handle offline threshold
+        //  Get the current time point using steady_clock
+        std::chrono::steady_clock::duration offline_duration = std::chrono::steady_clock::now() - time_disconnected;


Last thing for this, could you move it inside the if statement? That cleans this function up a bit more.

marcemmers · 2023-09-15T07:58:50Z

lib/ocpp/v201/charge_point.cpp

+                for (auto const& [evse_id, evse] : this->evses) {
+                    evse->trigger_status_notification_callbacks();
+                }
+            } else if (offline_duration <= offline_threshold_value) {


Suggested change

} else if (offline_duration <= offline_threshold_value) {

} else {

marcemmers · 2023-09-15T07:59:58Z

lib/ocpp/v201/charge_point.cpp

+            // B04.FR.01
+            // If offline period exceeds offline threshold then send the status notification for all connectors
+            if (offline_duration > offline_threshold_value) {
+                EVLOG_debug << "LIBOCPP: offline for more than offline threshold ";


Maybe remove the LIBOCPP: part of your debug prints? I think the logger already prints which module it comes from

Pietfried

Looks good apart from some minor styling remarks and a typo 👍

Pietfried · 2023-09-18T10:21:51Z

include/ocpp/v201/charge_point.hpp

@@ -133,6 +133,24 @@ class ChargePoint : ocpp::ChargingStationBase {
    int network_configuration_priority;
    bool disable_automatic_websocket_reconnects;

+    // store the connector status
+    struct evse_connector_pair {


we prefer CamelCase here

Pietfried · 2023-09-18T10:22:00Z

include/ocpp/v201/charge_point.hpp

+    // store the connector status
+    struct evse_connector_pair {
+        int32_t evse_id;
+        int32_t connectior_id;


Pietfried · 2023-09-18T10:23:11Z

lib/ocpp/v201/charge_point.cpp

+
+            // B04.FR.01
+            // If offline period exceeds offline threshold then send the status notification for all connectors
+            if (offline_duration > (std::chrono::seconds)this->device_model->get_value<int>(


nit: Prefer not to cast but use

std::chrono::seconds(this->device_model->get_value<int>( ControllerComponentVariables::OfflineThreshold))

instead

Pietfried · 2023-09-18T10:23:55Z

lib/ocpp/v201/charge_point.cpp

+        this->message_queue->pause();
+
+        // check if offline threshold has been defined
+        if ((std::chrono::seconds)this->device_model->get_value<int>(ControllerComponentVariables::OfflineThreshold) !=


Casting both to std::chrono::seconds not necessary here; Could just be

this->device_model->get_value<int>(ControllerComponentVariables::OfflineThreshold) != 0

Pietfried · 2023-09-18T10:28:21Z

include/ocpp/v201/charge_point.hpp

@@ -133,6 +133,24 @@ class ChargePoint : ocpp::ChargingStationBase {
    int network_configuration_priority;
    bool disable_automatic_websocket_reconnects;

+    // store the connector status
+    struct evse_connector_pair {


could also be defined publicly, I could imagine we could reuse this for other purposes. We could also move this later though

* Store the connector status when offline into a map * send status notification for changed connectors when back online Signed-off-by: Soumya Subramanya <s.subramanya@alfen.com> Signed-off-by: pietfried <pietgoempel@gmail.com>

SNSubramanya requested a review from Pietfried September 8, 2023 14:04

marcemmers requested changes Sep 11, 2023

View reviewed changes

SNSubramanya force-pushed the B04-OfflineBehaviour branch from fdb9dac to a91cac2 Compare September 12, 2023 11:26

marcemmers reviewed Sep 12, 2023

View reviewed changes

SNSubramanya force-pushed the B04-OfflineBehaviour branch 2 times, most recently from 236bd07 to 0aa1f65 Compare September 14, 2023 09:59

Pietfried requested a review from marcemmers September 14, 2023 12:32

marcemmers requested changes Sep 15, 2023

View reviewed changes

SNSubramanya force-pushed the B04-OfflineBehaviour branch from e84303c to 33cb132 Compare September 15, 2023 09:23

marcemmers approved these changes Sep 15, 2023

View reviewed changes

Pietfried requested changes Sep 18, 2023

View reviewed changes

Pietfried reviewed Sep 18, 2023

View reviewed changes

Pietfried force-pushed the B04-OfflineBehaviour branch from 82ca988 to 1c9e32a Compare September 18, 2023 12:04

Pietfried force-pushed the B04-OfflineBehaviour branch from 1c9e32a to 5b559d9 Compare September 18, 2023 12:06

Pietfried self-requested a review September 18, 2023 12:17

Pietfried approved these changes Sep 18, 2023

View reviewed changes

Pietfried merged commit 73c97f5 into main Sep 18, 2023
2 of 3 checks passed

Pietfried deleted the B04-OfflineBehaviour branch September 18, 2023 12:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

B04 offline idle behaviour #168

B04 offline idle behaviour #168

SNSubramanya commented Sep 8, 2023

marcemmers Sep 11, 2023

SNSubramanya Sep 11, 2023

marcemmers Sep 11, 2023

marcemmers Sep 11, 2023

marcemmers Sep 11, 2023

marcemmers Sep 11, 2023

marcemmers Sep 12, 2023 •

edited

Loading

marcemmers Sep 12, 2023

marcemmers Sep 15, 2023

marcemmers Sep 15, 2023

SNSubramanya Sep 15, 2023

marcemmers Sep 15, 2023

marcemmers Sep 15, 2023

marcemmers Sep 15, 2023

Pietfried left a comment

Pietfried Sep 18, 2023

Pietfried Sep 18, 2023

Pietfried Sep 18, 2023

Pietfried Sep 18, 2023

Pietfried Sep 18, 2023

		if (!(conn_state_per_evse[{evse_id,connector_id}].connector_status ==
		evse->get_state(connector_id))) {

-            if (is_offline_threshold_expired) {
+            auto offline_duration = std::chrono::steady_clock::now() - time_disconnected;
+            if (offline_duration >= offline_threshold_value) {


		std::map<conn_states_per_evse_id_key, ConnectorStatusEnum> conn_state_per_evse;

		std::chrono::seconds offline_threshold_value;

	} else if (offline_duration <= offline_threshold_value) {
	} else {

B04 offline idle behaviour #168

B04 offline idle behaviour #168

Conversation

SNSubramanya commented Sep 8, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcemmers Sep 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pietfried left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcemmers Sep 12, 2023 •

edited

Loading