Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to report and consume security events in OCPP1.6 #182

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

Pietfried
Copy link
Contributor

No description provided.

@RobertDeLeeuw
Copy link
Contributor

@Pietfried there is no checking for ciritical security events.
Now all libOCPP internal security events will get send to the CPMS, where A04.FR.01 says:

The Charge Point SHALL inform the Central System of the security events by sending a SecurityEventNotification.req, to the Central System.

We dont have to send them all. I have added this to the 2.0.1 implementation. Another boolean to the internal function.

@Pietfried
Copy link
Contributor Author

A04.FR.01

@RobertDeLeeuw I checked the spec and you are correct that only critical security events shall be sent. Still OCTT1.6 tests for SecurityEventRequests being sent like InvalidChargePointCertificate (which is not critical). I would propably go with just sending all of them, as this is not specifically prohibited in the spec as far as I can see. What do you think?

@Pietfried Pietfried force-pushed the pg-ocpp-external-security-event branch 2 times, most recently from 6996550 to e8f0122 Compare October 26, 2023 13:17
* now treating  SecurityEventNotification like transaction-related message
* Revert SecurityEvent enum back to strings

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: pietfried <pietgoempel@gmail.com>
@Pietfried Pietfried force-pushed the pg-ocpp-external-security-event branch from e8f0122 to 3c685f7 Compare October 26, 2023 13:30
@Pietfried Pietfried merged commit e865d20 into main Oct 26, 2023
3 checks passed
@Pietfried Pietfried deleted the pg-ocpp-external-security-event branch October 26, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants