Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with clang < 16 #183

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Fix build with clang < 16 #183

merged 4 commits into from
Sep 27, 2023

Conversation

hikinggrass
Copy link
Contributor

No description provided.

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Copy link
Contributor

@Dominik-K Dominik-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Building libocpp with clang-14 works now locally on my side.

@hikinggrass hikinggrass merged commit 743f697 into main Sep 27, 2023
3 checks passed
@hikinggrass hikinggrass deleted the kh-fix-clang-build branch September 27, 2023 10:57
bWF0dGhpYXMK pushed a commit to bWF0dGhpYXMK/libocpp that referenced this pull request Sep 27, 2023
* Prevent accidental usage of captured structured bindings (c++20 feature)
* Properly mark reconnect function with override
* Don't use /* within block comment
* clang-format

---------

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants