Added A04 Security Event Notification #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added fixes for TriggerMessage - FirmwareStatusNotification. |
Pietfried
force-pushed
the
rdl-201-security-event
branch
from
af6d093
to
61bbf25
Compare
Pietfried
approved these changes
Oct 2, 2023
hikinggrass
approved these changes
Oct 2, 2023
marcemmers
reviewed
Oct 11, 2023
| // specification of one of the Security Events in this list, for interoperability reasons, the Security Event from this | ||
| // list shall be used, instead of adding a new (proprietary) Security Event. | ||
|
|
||
| inline const std::string FIRMWARE_UPDATED = "FirmwareUpdated"; // CRITICAL |
There was a problem hiding this comment.
I was wondering why this approach was used for these values instead of using an enum and the conversion functions like we did for the other types?
There was a problem hiding this comment.
I choose this as it is not a fixed enum. It is a String in OCPP, and there is a given list of values. But this list can be extended. So it is more inline with OCPP.
* Only send critical events to the CSMS * L01.FR.02, L01.FR.02, L01.FR.31 * Fixed TriggerMessage for FirmwareStatusNotifcation for L01.FR.26 Signed-off-by: Robert de Leeuw, PIONIX <robert@pionix.de>
Pietfried
force-pushed
the
rdl-201-security-event
branch
from
61bbf25
to
68ff60a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added security events
Added publishing of events related to (re)boot and firmware update.