Uri: fix schema reporting #816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barsnick
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
"ws://" was being reported as secure. Use `get_scheme()` to also correctly report the supported (legacy) "http(s)" URIs. Fixes #697 Signed-off-by: Moritz Barsnick <moritz.barsnick@chargebyte.com>
barsnick
force-pushed
the
cb-fix-security-model-schema-reporting
branch
from
daf6153
to
c22b254
Compare
Pietfried
approved these changes
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"ws://" was being reported as secure.
Use
get_scheme()to also correctly report the supported (legacy) "http(s)" URIs.Describe your changes
Replace the typo
ws://with the actual schema fromget_scheme(). Also make this change for the correct use ofws://, to allow for potential legacyhttp://.Issue ticket number and link
#697
Checklist before requesting a review