Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smart charging: updated validation to be explicit when conforming profile #838

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

Pietfried
Copy link
Contributor

Original PR reopened: #815

Describe your changes

As part of the validation there are times, per the standard, that a profile needs to be modified to conform to the spec. During the initial pass we had this logic in validate methods and did not explicitly state that the modification was occurring.

  • renamed validate_profile to conform_and_validate_profile in order to convey the potential for change.
  • renamed validate_and_add_profile to conform_validate_and_add_profile in order to convey the potential for change.
  • added method conform_validity_periods to better show where the change is occurring.
  • added comment as to why the conform is being performed.
  • added logging to show the values that are being set.
  • added a new conform_schedule_number_phases function moving existing modification of the number of phases.
  • updated some methods to use const on profiles where attributes are not being modified.

Issue ticket number and link

Checklist before requesting a review

…ofile

Signed-off-by: Coury Richards <146002925+couryrr-afs@users.noreply.github.com>
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
Signed-off-by: Piet Gömpel <pietgoempel@gmail.com>
@Pietfried Pietfried merged commit f480fc0 into main Oct 25, 2024
4 checks passed
@Pietfried Pietfried deleted the feature/pg-update-validation-manipulation branch October 25, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants