Westlad/ping pong fix #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, I'm the one to blame for the ping-pong tests failing, sorry about that! |
|
I wouldn't worry. Tests always break eventually, unless they are part of the automated testing. |
Testing that a failed ping pong test is picked up.
fix: replace with correct code after action test
|
I see you have removed the Dockerfile inside |
|
Good point @daveroga. As this is a fairly urgent fix (for dev), I'll do a separate PR to remove the extraneous file. |
IlyasRidhuan
approved these changes
Feb 25, 2022
IlyasRidhuan
added
the
One more approval needed
daveroga
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ping-pong tests after some recent PRs broke it. Also runs an automated test on ping-pong to avoid future occurrences.
For instructions on running the ping-pong test, see
test/ping-pong/README.md.