Merge Browser into master #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyasRidhuan
requested review from
signorecello,
Westlad,
daveroga and
ChaitanyaKonda
IlyasRidhuan
force-pushed
the
wallet/nf-browser-v2
branch
2 times, most recently
from
0422687
to
3aba0f8
Compare
IlyasRidhuan
force-pushed
the
wallet/nf-browser-v2
branch
2 times, most recently
from
cd290c9
to
3f787ae
Compare
ChaitanyaKonda
suggested changes
Mar 10, 2022
IlyasRidhuan
force-pushed
the
wallet/nf-browser-v2
branch
from
e8c4cf6
to
628a6de
Compare
ChaitanyaKonda
approved these changes
Mar 14, 2022
ChaitanyaKonda
added
the
One more approval needed
Westlad
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finally adds the browser into master. Since it contains so many updates, the easiest way to review this PR would be to setup and run the wallet browser locally. 99% of changes are contained with the
/walletdirectory, however the single change of note tooptimistis the following:optimisthas a new web socket that passes L2 blockProposed events to the browser. This allows the browser to work with locally running optimist instances.Steps to setup
mkdir ./wallet/src/zokrates.aws s3 cp s3://nightfallv3/circuits ./wallet/src/zokrates --recursive./start-nightfall -g -s -d./proposerRun wallet
cd wallet && npm ci../copy-zokrates-local.shnpm startYour metamask must be configured to work with nightfall based on the steps in the README.
Note this should be SQUASHED MERGED given the commit quantity.