Fixing setup #537
Merged
Fixing setup #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signorecello
requested review from
Westlad,
ChaitanyaKonda,
daveroga and
druiz0992
daveroga
approved these changes
Feb 28, 2022
ChaitanyaKonda
approved these changes
Mar 2, 2022
|
Looks sound to me. |
LijuJoseJJ
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick PR to change two things:
setup-nightfallnow builds withdocker-compose.dev.ymlso it actually builds the image locally instead of pulling the existing imagedocker waitinstead of the existingsleep, I guess it can probably save a few minutes on the tests...