-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
David/proposer offchain #549
Conversation
Hey the tests failed because it turns out we were really almost over the limit on gas. Add another 0 to the gas cost and they should run fine 😅 Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is implemented fornightfall-client
.
I'm assuming you planned implement this for wallet after wallet's merge into master?
I can't find where to answer this comment, so i just put my answer here. My idea was to have @IlyasRidhuan do it as he knows how the wallet is structured. I wouldn't know where to start
BREAKING CHANGE: Because registerProposer function signature changes |
Fixes #524
This PR includes a proposer that exports two endpoints:
Additional changes included are:
proposers
contract. The proposer needs to have two endpoints implemented:getProposers
that return the next N proposers and the URLs so that a user can forward transactions directly. The URLs from proposers are extracted fromproposers.sol
contract directly.To test changes, simply run ping-pong test. If has been modified to alternate between onchain and offchain transactions. You can also test direct transactions with cli tools (launching
./nf
and requesting offchain transactions).NOTE: I had to merge PR with #514 because there were changes to ping pong test that were required.