Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

David/staging2 #570

Merged
merged 8 commits into from
Mar 17, 2022
Merged

David/staging2 #570

merged 8 commits into from
Mar 17, 2022

Conversation

druiz0992
Copy link
Contributor

@druiz0992 druiz0992 commented Mar 10, 2022 •
edited
Loading

Minor changes to be compatible with staging/prod.

  • heartbeat function to keep websocket alive. AWS closes idle connections after 1 minute
  • Some additional logging to track websockets

@druiz0992 druiz0992 self-assigned this Mar 10, 2022
@druiz0992 druiz0992 requested a review from Westlad March 10, 2022 23:34
ChaitanyaKonda
ChaitanyaKonda reviewed Mar 11, 2022
View reviewed changes
cli/lib/nf3.mjs Outdated Show resolved Hide resolved
ChaitanyaKonda
ChaitanyaKonda suggested changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@ChaitanyaKonda ChaitanyaKonda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change requested

@ChaitanyaKonda ChaitanyaKonda added the One more approval needed One reviewer has approved this PR but another is needed label Mar 14, 2022
@druiz0992 druiz0992 removed Merge conflict One more approval needed One reviewer has approved this PR but another is needed labels Mar 15, 2022
@Westlad Westlad merged commit b8f549e into master Mar 17, 2022
@Westlad Westlad deleted the david/staging2 branch March 17, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaitanyaKonda ChaitanyaKonda ChaitanyaKonda approved these changes

@daveroga daveroga daveroga approved these changes

@signorecello signorecello Awaiting requested review from signorecello

@Westlad Westlad Awaiting requested review from Westlad

Assignees

@druiz0992 druiz0992

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@druiz0992 @ChaitanyaKonda @daveroga @Westlad