Timber updates sibling paths using incoming leaves. #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #581 and is proof that #540 can be solved statelessly. Activating this functionality across
client
,optimist
andwallet
is sufficiently large and complex to warrant another PR.This PR allows Timber to statelessly update a sibling path for a leaf index to account for the insertion of new leaves. This removes the restriction that spending commitments must reference the block these commitments were "mined" in.
Unit/Property tests (
Check Sibling Path Increment
) are included and can be run usingnpx mocha --timeout 0 --bail --exit test/timber.test.mjs
Note There is duplication as the common-files update must also happen in the
wallet
directory. These can't share the sametimber
file due to a restriction increate-react-app
including files outside ofwallet/src