Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing .block when accessing historical blocks. #585

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Missing .block when accessing historical blocks. #585

merged 1 commit into from
Mar 21, 2022

Conversation

IlyasRidhuan
Copy link
Contributor

The array of objects received from the sync endpoint is incorrectly accessed. The blockNumberL2 field is within the block field.

@IlyasRidhuan IlyasRidhuan temporarily deployed to AWS March 17, 2022 17:35 Inactive
@signorecello signorecello self-requested a review March 18, 2022 11:00
@Westlad Westlad added bug-fix and removed bug labels Mar 18, 2022
@ChaitanyaKonda ChaitanyaKonda merged commit a45394b into master Mar 21, 2022
@ChaitanyaKonda ChaitanyaKonda deleted the ilyas/sync-fix branch March 21, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@signorecello signorecello signorecello approved these changes

@ChaitanyaKonda ChaitanyaKonda ChaitanyaKonda approved these changes

@LijuJoseJJ LijuJoseJJ Awaiting requested review from LijuJoseJJ

@druiz0992 druiz0992 Awaiting requested review from druiz0992

@luizoamorim luizoamorim Awaiting requested review from luizoamorim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IlyasRidhuan @signorecello @ChaitanyaKonda @Westlad