-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nonce from pending and fixing nonce order #589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaitanyaKonda
force-pushed
the
chait/nonce
branch
from
March 21, 2022 15:55
eda4166
to
10fdbf0
Compare
signorecello
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but there's a possible duplicate log
ChaitanyaKonda
force-pushed
the
chait/nonce
branch
from
April 4, 2022 03:13
07b94ce
to
10c6394
Compare
Westlad
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #565
This PR
This can be tested by adding the test file below into
test/e2e/tokens
, skipping other tests in this folder by adding.hold
to its files name and runningnpm run test-e2e-tokens
. Start a proposer after seeing the messageTransfers submitted. Start Proposer
. This should create an array of transfer transaction L2 blocks and submit at once. If the test is successful, then L2 blocks have been submitted in the right nonce order by the proposer.Test file to