Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove browser e2e test GitHub actions workflow #606

Merged

Conversation

LijuJoseJJ
Copy link
Contributor

This PR comment out github actions workflow which test browser e2e test, for two reason.

  1. currently in master browser e2e test are broken because significant change in UI.
  2. since we are tight with deliverable it is getting bit tedious to keep changing e2e test workflow with change in code.

Understanding is, later this will be reverted back

@Westlad
Copy link
Contributor

Westlad commented Apr 6, 2022

What are the changes in wallet/src/nightfall-browser/services/withdraw.js for? At first sight they seem to go deeper than a linter fix.

@IlyasRidhuan
Copy link
Contributor

It looks like linter updates (with a rename from items -> withdrawParams) ;

I'll have a check of the eslint for the wallet in a later PR, it looks like it needs some work

@Westlad Westlad self-requested a review April 6, 2022 14:19
@Westlad Westlad merged commit 722bc6e into master Apr 6, 2022
@Westlad Westlad deleted the liju.jose/remove-browser-e2e-test-github-actions-workflow branch April 6, 2022 14:20
@Westlad Westlad restored the liju.jose/remove-browser-e2e-test-github-actions-workflow branch April 6, 2022 14:22
@Westlad Westlad deleted the liju.jose/remove-browser-e2e-test-github-actions-workflow branch April 6, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants