Local Development Environment For Wallet #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyasRidhuan
requested review from
ChaitanyaKonda,
LijuJoseJJ,
luizoamorim and
signorecello
|
After running the wallet up following all the instructions and I run into this error
|
Westlad
approved these changes
Apr 21, 2022
|
Clearing indexDb, local storage and reseting the account in Metamask cleared the error for me. |
Westlad
added
One more approval needed
IlyasRidhuan
force-pushed
the
wallet/local-dev
branch
from
af30bf4
to
a2e642e
Compare
ChaitanyaKonda
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a local development environment for the wallet that now starts up using
npm run start.It does this using an environment variable
REACT_APP_MODE- the prefixREACT_APPis a requirement for browser environments. This environment determines the list of tokens to be used in the wallet -supported-token-list.Note that the value for the
ERC20Mockis hardcoded for now, it will always be the same deployed address provided we do not make modifications to the deployment process we currently have. Doing this dynamically usinggetContractAddressfromoptimistis a possibility but ends up being messier due to thepromisehandling.This PR also includes some
eslintfixes andaliasfor some deep directories (reducing the unwieldiness of long../../..imports) as well as updates to the README.To Test
npm cinpm run startERC20Mockaddress.