Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit input in Bridge and Send to 4 decimals #616

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

IlyasRidhuan
Copy link
Contributor

This PR just prevents users from inputting more than 4 decimals as a transfer value.

This isn't because we cannot handle more - but it's a way to mitigate a user doing something silly, e.g. adding more decimal places than is supported by the token's ERC20 contract.

To Test

  • npm ci
  • nom run start
  • when using the browser, try to input more than 4 decimals in the Bridge or Send areas.

@ChaitanyaKonda ChaitanyaKonda added the One more approval needed One reviewer has approved this PR but another is needed label Apr 21, 2022
@Westlad Westlad self-requested a review April 21, 2022 14:55
@Westlad Westlad merged commit 1740fdd into master Apr 21, 2022
@Westlad Westlad deleted the limit-input-length branch April 21, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
One more approval needed One reviewer has approved this PR but another is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants