BigInt changes to core Nightfall #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
force-pushed
the
westlad/decimals-struct
branch
from
02ec49d
to
2c21ca2
Compare
Westlad
force-pushed
the
ilyas/core-big-int
branch
from
4d2fe45
to
480897b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off-chain endpoint and the transaction-checker are updated to not cast to a
Number. Currently these are truncated given the newuint112This can be tested by modifying the truffle migrations file to increase the token supply and minted amounts to
> 2**64and attempting to spend.Finally, there is still a
Numbercast reference in the variousgetWalletBalancecalls inclient. Unfortunately this is a large, albeit mechanical, change as the function is used in all the test files.