Small Wallet Bugs #627
Merged
Small Wallet Bugs #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
approved these changes
Apr 27, 2022
Westlad
added
the
One more approval needed
druiz0992
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few small bugs discovered due pre-prod deployment.
Wallet submitTransaction: Setting a
msg.valuein the transaction toShield.submitTransactionsets a previously zero state in thefeeBook. This additional gas requirement is not detected in theestimateGasfunction. As a result, the gasLimit is too low sometimes (we attempted to minimise this using a 10% buffer - this is now increased to 50%).UI in bridge page wasn't correctly being formatted because we were incorrectly mixing between string and bigInt types.
The use of
global.configin the web worker breaks in production deployment (but not in local development). This is likely due to a difference in thewebpack buildvswebpack dev serverenvironments.