blocks can be made at any point in time #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
requested review from
IlyasRidhuan,
signorecello,
ChaitanyaKonda and
druiz0992
druiz0992
approved these changes
Apr 28, 2022
Westlad
added
the
One more approval needed
daveroga
added
One more approval needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
optimistendpoint/block/make-now(and wrappers it in the Nf3 class methodmakeBlockNow). When called,optimistwill make a 'short' block using whatever transactions it has in its database, even if that is less thanTRANSACTIONS_PER_BLOCK. The short block is still made by queuingconditionalMakeBlockin the usual way, so the queue is never bypassed. The new code will not make a block if there are no transactions: there must be at least one. If there are already >=TRANSACTIONS_PER_BLOCKtransactions, then calling this endpoint has no effect.To test, an additional test stanza has been added to the ERC1155 tests, whereby
makeBlockNowis called and a single deposit transaction is made. The test then waits for a block to be created. Normally it would wait forever (well, until it times out) but because the end point has been called, a block with a single transaction will be made. you can double check this by looking at the logs and you will find a block with atransactionHashesof length 1, rather than 2.