add amount restrictions for mainnet and goerli ERC contracts #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westlad
requested review from
IlyasRidhuan,
signorecello,
ChaitanyaKonda and
druiz0992
druiz0992
reviewed
Apr 29, 2022
druiz0992
reviewed
Apr 29, 2022
druiz0992
approved these changes
Apr 29, 2022
Westlad
added
the
One more approval needed
daveroga
approved these changes
Apr 29, 2022
daveroga
removed
the
One more approval needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the test code that put restrictions on the amount that can be deposited or withdrawn.
It selects the contract addresses to put limits on via the environment variable
ETH_NETWORKwhich is the same one used to select the truffle configuration for deployment, so it's transparent to the deployer. Value restrictions are created in the contract migration.Test in the normal way, although obviously it's not possible to directly test mainnet and goerli values. However the symmetry between those and the ganache (
ETH_NETWORK=blockchain1) case.