transactionHashesRoot calculated in proposeBlock without challenge #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyasRidhuan
reviewed
May 6, 2022
IlyasRidhuan
approved these changes
May 6, 2022
ChaitanyaKonda
added
One more approval needed
druiz0992
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
blockHashbeing calculated fromblock struct object(includingtransactionHashesRoot) andtransactionsHashto justblock struct object(includingtransactionHashesRoot). Also,transactionHashesRootis now calculated during proposeBlock and so it does not need to be challenged anymore.Test: This is automatically tested by github actions.
dc6d7464bcc97d16ad2f1ba32aeda82ea25298d1when finalise withdrawal needed sending all transactions as calldata