Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser-fixes-1 #645

Merged
merged 2 commits into from
May 9, 2022
Merged

Browser-fixes-1 #645

merged 2 commits into from
May 9, 2022

Conversation

IlyasRidhuan
Copy link
Contributor

This PR adds two things.

  1. Approval are properly checked now, so we only request approvals in deposits if we truly are out of allowance.
  2. "Graceful" error handling of failed proof generation

@druiz0992 druiz0992 merged commit a845623 into master May 9, 2022
@druiz0992 druiz0992 deleted the ilyas/browser-fixes branch May 9, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Westlad Westlad Westlad approved these changes

@druiz0992 druiz0992 druiz0992 approved these changes

@ChaitanyaKonda ChaitanyaKonda Awaiting requested review from ChaitanyaKonda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IlyasRidhuan @Westlad @druiz0992