Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix upgrade contracts #651

Merged
merged 2 commits into from
May 10, 2022
Merged

Fix upgrade contracts #651

merged 2 commits into from
May 10, 2022

Conversation

daveroga
Copy link
Contributor

State contract reference was missing in the upgrade script

Westlad
Westlad requested changes May 10, 2022
View reviewed changes
Copy link
Contributor

@Westlad Westlad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there not be a line to deploy an upgradeProxy for State?

@daveroga
Copy link
Contributor Author

I thought the state couldn't be migrated with the plugin. But I read that the state is preserved. So yes, upgradeProxy for State was missing. Added.

@daveroga daveroga requested a review from Westlad May 10, 2022 14:29
@Westlad Westlad merged commit f68fdbd into master May 10, 2022
@Westlad Westlad deleted the daveroga/fix-upgrade-contracts-state branch May 10, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaitanyaKonda ChaitanyaKonda ChaitanyaKonda approved these changes

@Westlad Westlad Westlad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daveroga @Westlad @ChaitanyaKonda @druiz0992