This repository has been archived by the owner on Mar 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bit of ugliness to allow passing arguments through to criterion without issues, in that we must explicitly put
bench = false
in all of the Cargo.toml files for the crates in the workspace. It's something that is being looked at upstream.See:
Checklist
cargo xtask fixup
for formatting and lintingCHANGELOG.md
per "Keep a Changelog" format