-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only phone app branch #16
base: master
Are you sure you want to change the base?
Conversation
phoneApp/src/js/view.js
Outdated
@@ -1,6 +1,59 @@ | |||
class View{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not required to name it View. it could be a "mental abstraction" in your head.
On complex projects, MVC could be hidden, but from the relationships between classes/functions you would feel MVC :)
"it's smell like MVC"
phoneApp/src/js/view.js
Outdated
} | ||
|
||
createStructure(){ | ||
this.baseContainer.innerHTML += this.createHeader() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks weird, no need to create different blocks for it. just paste a html layout is fine
No description provided.