Added the bash book to the books section #2493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have attempted to add the bash book to the book section again. There was an issue the last time , i tried to propose the file change as i had not placed it in alphabetical order. Someone please review this :)
|
'space' < a in the collation |
|
I am sorry, but could you please elaborate? I didnt understand what 'space' < a meant! |
|
Sorry, I was in a hurry. Look at the Travis-CI output. The linter complains that the books are not in alphabetical order. so "Bash tutorial" comes before "BashGuide" because " " comes before "G". |
|
this PR is for #2482 |
|
Looks like this PR has been abandoned? Might be worth closing out |
benjnse
pushed a commit
to benjnse/free-programming-books
that referenced
this pull request
Dec 5, 2017
* Added the bash book to the books section I have attempted to add the bash book to the book section again. There was an issue the last time , i tried to propose the file change as i had not placed it in alphabetical order. Someone please review this :) * fixed alphabetization
ruimartinsptl
pushed a commit
to ruimartinsptl/free-programming-books
that referenced
this pull request
May 22, 2019
* Added the bash book to the books section I have attempted to add the bash book to the book section again. There was an issue the last time , i tried to propose the file change as i had not placed it in alphabetical order. Someone please review this :) * fixed alphabetization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have attempted to add the bash book to the book section again. There was an issue the last time , i tried to propose the file change as i had not placed it in alphabetical order. Someone please review this :)