Missing test case in the urlParser.

Caused a bug for existing projects where the routes were parsed in the wrong order, causing the last route to be the default.
EdJ · Jun 13, 2013 · 56f1310 · 56f1310
1 parent e866c08
commit 56f1310
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/Routes/urlParser.js b/Routes/urlParser.js
@@ -32,7 +32,7 @@ module.exports = (function() {
         var pattern;
         var output;
 
-        for (var i = patterns.length; i--;) {
+        for (var i = 0, l = patterns.length; i < l; i++) {
             pattern = patterns[i];
 
             output = pattern.func(path);

diff --git a/test/Routes/urlParser.js b/test/Routes/urlParser.js
@@ -187,7 +187,36 @@ describe('UrlParser', function() {
 					}
 				}
 			], ['/Content']);
-
+
+			var path = parseUrl('/test/test.html');
+
+			path.should.eql({
+				test: 'data',
+				_isStatic: false
+			});
+		});
+
+		it('should check the routes in order.', function() {
+			var parseUrl = urlParser([{
+					func: function() {
+						return {};
+					},
+					data: {
+						test: 'data'
+					}
+				}, {
+
+					func: function() {
+						return {
+							wrongData: true
+						}
+					},
+					data: {
+						nope: 'not this one.'
+					}
+				}
+			], ['/Content']);
+
 			var path = parseUrl('/test/test.html');
 
 			path.should.eql({