Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Docs(local-development guide): Add a step to local development using Docker #10214

Merged

Conversation

ArvindParekh
Copy link
Member

@ArvindParekh ArvindParekh commented Feb 2, 2024

Fixes Issue

fixes #9830

Changes proposed

Added an extra step that informes users to check if their docker daemon is running, which is required to handle docker commands. The optimal way is to launch the Docker Desktop applications, available for Windows, Mac and Linux, which will start the daemon automatically in the background. If the users have installed docker through the cli, I've asked them to refer to the official documentation here which lists the commands to run the daemon, based on the operating system.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Before:

image

After:

image

Note to reviewers

@github-actions github-actions bot added the 📖 docs Documentation pages label Feb 2, 2024
@ArvindParekh
Copy link
Member Author

Do you think we should also update the process in our readme, in a more shorter format?

image

@SaraJaoude SaraJaoude added the issue linked Pull Request has issue linked label Feb 4, 2024
Copy link
Member

@eddiejaoude eddiejaoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@eddiejaoude eddiejaoude merged commit 0c16228 into EddieHubCommunity:main Feb 15, 2024
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 docs Documentation pages issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add a step to docker startup guide
3 participants