Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Dadu dev patch 1 #5088

Merged
merged 8 commits into from
Feb 26, 2023
Merged

Conversation

DaduDev
Copy link
Contributor

@DaduDev DaduDev commented Feb 26, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added large Pull request with more than 30 changed lines ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Feb 26, 2023
@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 and removed large Pull request with more than 30 changed lines labels Feb 26, 2023
Panquesito7
Panquesito7 previously approved these changes Feb 26, 2023
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

SurajPratap10
SurajPratap10 previously approved these changes Feb 26, 2023
schmelto
schmelto previously approved these changes Feb 26, 2023
iamthecloverly
iamthecloverly previously approved these changes Feb 26, 2023
data/DaduDev.json Show resolved Hide resolved
data/DaduDev.json Outdated Show resolved Hide resolved
Co-authored-by: Will Beebe <will@containerlabs.io>
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit abcdef7 into EddieHubCommunity:main Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants