This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Dadu dev patch 1 #5088
Merged
kumarsonsoff3
merged 8 commits into
EddieHubCommunity:main
from
DaduDev:DaduDev-patch-1
Feb 26, 2023
Merged
Dadu dev patch 1 #5088
kumarsonsoff3
merged 8 commits into
EddieHubCommunity:main
from
DaduDev:DaduDev-patch-1
Feb 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: David Leal <halfpacho@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great having you contribute to this project
Welcome to the community 🤓If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.
github-actions
bot
added
large
Pull request with more than 30 changed lines
✍ chore: profile
This label will be added on PR with request of Data json addition
LGTM
labels
Feb 26, 2023
github-actions
bot
added
medium
Pull request with changed lines between 10 and 30
and removed
large
Pull request with more than 30 changed lines
labels
Feb 26, 2023
Panquesito7
previously approved these changes
Feb 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🎉
SurajPratap10
previously approved these changes
Feb 26, 2023
schmelto
previously approved these changes
Feb 26, 2023
iamthecloverly
previously approved these changes
Feb 26, 2023
WillBeebe
reviewed
Feb 26, 2023
Co-authored-by: Will Beebe <will@containerlabs.io>
DaduDev
dismissed stale reviews from iamthecloverly, schmelto, SurajPratap10, and Panquesito7
via
February 26, 2023 13:37
9348cfd
SurajPratap10
approved these changes
Feb 26, 2023
kumarsonsoff3
approved these changes
Feb 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Thanks! 🎉
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
✍ chore: profile
This label will be added on PR with request of Data json addition
LGTM
medium
Pull request with changed lines between 10 and 30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers