Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

data: a-y-a-n-das #5280

Merged

Conversation

a-y-a-n-das
Copy link
Contributor

@a-y-a-n-das a-y-a-n-das commented Mar 6, 2023

data: a-y-a-n-das

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

data: a-y-a-n-das
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@github-actions github-actions bot added medium Pull request with changed lines between 10 and 30 ✍ chore: profile This label will be added on PR with request of Data json addition LGTM labels Mar 6, 2023
Krishnapro
Krishnapro previously approved these changes Mar 6, 2023
Copy link
Member

@Krishnapro Krishnapro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 it will be better if you remove the extra space from lines 21 to 26.

@a-y-a-n-das
Copy link
Contributor Author

Done

@a-y-a-n-das a-y-a-n-das closed this Mar 6, 2023
@a-y-a-n-das a-y-a-n-das reopened this Mar 8, 2023
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks for your Contribution! 🎉

@kumarsonsoff3 kumarsonsoff3 merged commit 8abe4d8 into EddieHubCommunity:main Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition LGTM medium Pull request with changed lines between 10 and 30
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants