Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

chore: add Aaquib Ali #975

Merged
merged 2 commits into from
Jan 14, 2022
Merged

chore: add Aaquib Ali #975

merged 2 commits into from
Jan 14, 2022

Conversation

imaaquibali
Copy link
Member

@imaaquibali imaaquibali commented Jan 12, 2022

Fixes Issue

Changes proposed

Adding links to linkfree in public/data

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@EmmaDawsonDev EmmaDawsonDev added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jan 12, 2022
@EmmaDawsonDev EmmaDawsonDev changed the title Adding profile in public/data chore: add Aaquib Ali Jan 12, 2022

]
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the formatting isn't correct It will be done by actions

@imaaquibali
Copy link
Member Author

@krishguptadev i done the modification check again if you find any problem plesae tell....?

@imaaquibali
Copy link
Member Author

@vikasganiga05 when this Pr is closed..?

@vikasganiga05
Copy link
Member

@vikasganiga05 when this Pr is closed..?

I don't know. It depends on the maintainers. They will do a final review and merge this PR. 🙂

@EmmaDawsonDev
Copy link
Member

@aaquibdev We usually aim for 2 maintainers to approve the PR before merging :)

Copy link
Member

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the contribution :D.

@Panquesito7 Panquesito7 merged commit d5ea171 into EddieHubCommunity:main Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✍ chore: profile This label will be added on PR with request of Data json addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants