Skip to content
This repository has been archived by the owner on Aug 7, 2024. It is now read-only.

Changed old twitter icon to X #9972

Merged
merged 8 commits into from
Jan 19, 2024

Conversation

krushnarout
Copy link
Member

Fixes Issue

Closes #9971

Changes proposed

Changed old twitter icon to new X icon.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added the issue linked Pull Request has issue linked label Dec 20, 2023
Copy link
Member

@Sindhuinti Sindhuinti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚢

Copy link
Member

@adityaraute adityaraute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For those wondering what's the difference between the two

image

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seems a bit straight to me, but it gives the following error when we click on the share icon on someone's profile.

image

@krushnarout
Copy link
Member Author

@kumarsonsoff3 I think you forget to add BsTwitterX on import { BsTwitter, BsFacebook, BsLinkedin } from "react-icons/bs"; while checking. Can you double check it?

@ChinmayMhatre
Copy link
Member

Changes seems a bit straight to me, but it gives the following error when we click on the share icon on someone's profile.

image

This might be a separate issue. Can you share which page and which icon. maybe steps to reproduce?

@kumarsonsoff3
Copy link
Member

kumarsonsoff3 commented Jan 9, 2024

This might be a separate issue. Can you share which page and which icon. maybe steps to reproduce?

I thought the same, but either this icon BsTwitter is used in some other module that needs update or something else.

@adityaraute
Copy link
Member

This clip confirms that the PR creates issues that needs to be addressed.
The modal is probably bugging because of the missing icon. thanks for sharing @kumarsonsoff3

@krushnarout
Copy link
Member Author

krushnarout commented Jan 18, 2024

@adityaraute Can anyone tell me, how can I fix this ?

@adityaraute
Copy link
Member

You have updated your branch and so there is no difference between your fork and this repo at the moment.
You'll have to once again commit your changes to your branch and then the PR will be mergeable.

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jan 19, 2024
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jan 19, 2024
@krushnarout
Copy link
Member Author

@kumarsonsoff3 I've fixed the error, Please check and let me know any changes needed.

Screenshot

bio

Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome. Great collaboration everyone. 👍

@kumarsonsoff3 kumarsonsoff3 merged commit 6eb7ef4 into EddieHubCommunity:main Jan 19, 2024
11 checks passed
@krushnarout krushnarout deleted the change-icon branch January 19, 2024 16:37
@krushnarout
Copy link
Member Author

Thank you everyone

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue linked Pull Request has issue linked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Request to update Twitter icon to X on social share
6 participants