fix: button to allow props like target (#272)

EddieHubCommunity · Oct 4, 2024 · b592035 · b592035
1 parent dde830e
commit b592035
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/components/Button.js b/src/components/Button.js
@@ -1,10 +1,11 @@
 import Link from "next/link";
 import classNames from "@/utils/classNames";
 
-export default function Button({ url, type = "primary", children }) {
+export default function Button({ url, type = "primary", children, ...props }) {
   return (
     <Link
       href={url}
+      {...props}
       className={classNames(
         "inline-flex items-center gap-x-2 rounded-md px-3.5 py-2.5 text-sm font-semibold shadow-sm focus-visible:outline focus-visible:outline-2 focus-visible:outline-offset-2",
         type === "primary" &&

diff --git a/src/components/Heading.js b/src/components/Heading.js
@@ -28,7 +28,7 @@ export default function Heading({ title, actions = [], extras = [] }) {
         <div className="mt-5 flex lg:ml-4 lg:mt-0">
           {actions.map((action) => (
             <span className="sm:ml-3" key={action.icon}>
-              <Button url={action.url}>
+              <Button url={action.url} target="_blank">
                 <action.icon
                   aria-hidden="true"
                   className="-ml-0.5 mr-1.5 h-5 w-5"