fix: location update (#284)

EddieHubCommunity · Jun 16, 2022 · 8f37d8b · 8f37d8b
1 parent c6bf29a
commit 8f37d8b
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 16 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/github/github-profile.service.ts b/src/github/github-profile.service.ts
@@ -76,23 +76,28 @@ export class GithubProfileService {
           HttpStatus.NOT_FOUND,
         );
       }
-      if (!githubProfile.location) {
-        return await this.githubModel.findByIdAndUpdate(
-          github,
-          {
-            $inc: {
-              __v: 1,
-            },
-          },
-          { new: true },
-        );
-      }
+      const data = await lastValueFrom(
+        this.getGithubProfile(github).pipe(
+          concatMap(async (githubData) => {
+            Object.keys(githubData).forEach((key) => {
+              if (githubData[key] === null) {
+                delete githubData[key];
+              }
+            });
+            if (!githubData.location) return githubData;
+            return {
+              location: await this.geocodingService.fetchCoordinates(
+                githubData.location,
+              ),
+              name: githubData.name,
+            };
+          }),
+        ),
+      );
       return await this.githubModel.findByIdAndUpdate(
         github,
         {
-          location: await this.geocodingService.fetchCoordinates(
-            githubProfile.location.provided,
-          ),
+          location: data.location,
           $inc: {
             __v: 1,
           },