Handle sflow packet with gaps between samples #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dbardbar. I am going through the PRs one by one, I will take a look at this next week. |
|
Any news on this? I'll be happy to answer any questions about this PR, or any of the others. |
|
Looks good to me. Tested by using TCP replay (tcpreplay -i bond0 /root/sflow_padding_between_samples-fixed.pcap) and using internal replay: ./vflow/replay-traffic/replay --interface bond0 --pcap /root/sflow_padding_between_samples-fixed.pcap ...^CProcessed a total of 1 messages Noted that this message is not parsed correctly without this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173