Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add user filed to get problem set grades API #142

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

qianxi66
Copy link
Contributor

@qianxi66 qianxi66 commented May 6, 2024

实现#132
Class管理员,查询该Class中某一ProblemSet的全部用户成绩 需求。
继承#133pr的代码写的。

Copy link

github-actions bot commented May 6, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@leoleoasd leoleoasd changed the title 教师查询某一problemset成绩,修改接口 fix: Add user filed to get problem set grades API Jun 25, 2024
Comment on lines 132 to 141
emptyDetail, err := json.Marshal(detail) // 将map转换为JSON格式
if err != nil {
// 如果转换失败,记录错误并返回
log.Errorf("Error marshalling grade detail for empty grade: %v", err)
return errors.Wrap(err, "could not marshal grade detail for empty grade")
}

// 打印转换后的JSON日志
log.Errorf("Empty detail JSON: %s", emptyDetail)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write comments in English

leoleoasd
leoleoasd previously approved these changes Jun 26, 2024
Copy link
Member

@leoleoasd leoleoasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qianxi66
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Member

@leoleoasd leoleoasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoleoasd leoleoasd merged commit aec6cf1 into EduOJ:master Jun 30, 2024
8 of 19 checks passed
@qianxi66 qianxi66 deleted the new-branch branch November 6, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants