Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cause - 错因系统 #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cause - 错因系统 #99

wants to merge 1 commit into from

Conversation

suntt2019
Copy link
Member

closes #98

@suntt2019 suntt2019 requested a review from leoleoasd August 29, 2021 05:53
@suntt2019 suntt2019 self-assigned this Aug 29, 2021
@suntt2019 suntt2019 changed the title Add models, migration, requests, responses and routes for cause Cause - 错因系统 Aug 29, 2021
@codecov
Copy link

codecov bot commented Aug 29, 2021 •
edited
Loading

Codecov Report

Merging #99 (0237381) into master (0b82c49) will decrease coverage by 8.44%.
The diff coverage is 27.95%.

❗ Current head 0237381 differs from pull request most recent head b6ecae5. Consider uploading reports for the commit b6ecae5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   72.73%   64.29%   -8.45%     
==========================================
  Files          55       58       +3     
  Lines        5315     5568     +253     
==========================================
- Hits         3866     3580     -286     
- Misses       1223     1787     +564     
+ Partials      226      201      -25
Impacted Files Coverage Δ
app/controller/cause.go 0.00% <0.00%> (ø)
app/response/resource/cause.go 0.00% <0.00%> (ø)
database/models/submission.go 0.00% <ø> (ø)
app/controller/judger.go 66.00% <20.00%> (-0.83%) ⬇️
base/utils/cause.go 63.41% <63.41%> (ø)
database/migrate.go 56.40% <91.66%> (-32.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b82c49...b6ecae5. Read the comment docs.

leoleoasd
leoleoasd requested changes Aug 29, 2021
View reviewed changes
app/response/resource/cause.go
ProblemID uint `json:"problem_id"`
TestCaseID uint `json:"test_case_id"`

Hash string `json:"output_stripped_hash"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

json就叫hash就行？

@suntt2019 suntt2019 force-pushed the dev/cause branch 8 times, most recently from d084bfd to b6ecae5 Compare September 2, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoleoasd leoleoasd leoleoasd requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@suntt2019 suntt2019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

错因系统
2 participants
@suntt2019 @leoleoasd