Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Fixed some duplicated tests and deprecated tests #54

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(test): Fixed some duplicated tests and deprecated tests #54

merged 1 commit into from
Oct 17, 2023

Conversation

Jatewo
Copy link
Contributor

@Jatewo Jatewo commented Oct 17, 2023

Description

Fixed some duplicated and deprecated tests and a mixup in the course routes.

Changes

  • Reworked adminOnly tests to make use of a test route
  • Deleted duplicated tests for courseRoutes
  • Removed /courses from within courseRoutes
  • Made a test route for adminOnly

Related Issues

This is a solution to issue #52 - [Backend] Course routes needs updating

Checklist

  • Code has been tested locally and passes all relevant tests.
  • Documentation has been updated to reflect the changes, if applicable.
  • Code follows the established coding style and guidelines of the project.
  • All new and existing tests related to the changes have passed.
  • Any necessary dependencies or new packages have been properly documented.
  • Pull request title and description are clear and descriptive.
  • Reviewers have been assigned to the pull request.
  • Any potential security implications have been considered and addressed.
  • Performance impact of the changes has been evaluated, if relevant.

@Jatewo
fix(test): Fixed some duplicated and deprecated tests
29c2185 
- Reworked adminOnly tests to make use of a test route
- Deleted duplicated tests for courseRoutes
- Removed /courses from within courseRoutes
- Made a test route for adminOnly
@Jatewo Jatewo linked an issue Oct 17, 2023 that may be closed by this pull request
[Backend] Course routes needs updating #52
Closed
@Mafusn Mafusn merged commit e0a4ff2 into dev Oct 17, 2023
2 checks passed
@Jatewo Jatewo mentioned this pull request Oct 18, 2023
Merged
9 tasks
@Jatewo Jatewo deleted the dev-test-fix branch November 3, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mafusn Mafusn Mafusn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Backend] Course routes needs updating
2 participants
@Jatewo @Mafusn