Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

determine cmake version #172

Closed
wants to merge 1 commit into from
Closed

determine cmake version #172

wants to merge 1 commit into from

Conversation

VoidxHoshi
Copy link
Contributor

Determine cmake version to avoid long and meaningless warning logs

Determine cmake version to avoid long and meaningless warning logs
@asuka-mio
Copy link
Member

Newer cmake has some issues with ndk
android/ndk#1693

@asuka-mio
Copy link
Member

@VoidxHoshi
Copy link
Contributor Author

well, 👍 and 😢

@VoidxHoshi VoidxHoshi closed this Aug 9, 2022
@asuka-mio
Copy link
Member

And archlinux's cmake is 3.23.3 now, other distribution may be lower, so it's not a good idea to specific a cmake version

@txyyh
Copy link
Collaborator

txyyh commented Aug 9, 2022

Such as fdroid official build server

They use Debian stretch

@asuka-mio
Copy link
Member

Maybe we can apply some tricks to silence this warning

@VoidxHoshi
Copy link
Contributor Author

And archlinux's cmake is 3.23.3 now, other distribution may be lower, so it's not a good idea to specific a cmake version

well, 3.22.1 is the latest cmake version in Android SDK toolchain. It's in the SDK (installed by sdkmanager) rather than the Path (you manually installed)

@asuka-mio
Copy link
Member

asuka-mio commented Aug 9, 2022

well, 3.22.1 is the latest cmake version in Android SDK toolchain. It's in the SDK (installed by sdkmanager) rather than the Path (you manually installed)

That's because android's cmake changes has been merged into cmake upstream, newer cmake has android ndk support itself
So ndk team is unnecessary to maintain a cmake fork themselves

@asuka-mio
Copy link
Member

That's why they need a new toolchain file
But some bugs haven't been fixed yet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants