Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github pass / fail badge not accurate anymore #54

Open
rhaas80 opened this issue Feb 21, 2023 · 0 comments
Open

github pass / fail badge not accurate anymore #54

rhaas80 opened this issue Feb 21, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rhaas80
Copy link
Member

rhaas80 commented Feb 21, 2023

GitHub's pass / fail badge is based on the state of the workflow. Right now however this no longer correctly set and leads to a failing test not showing up:

image

There's code in the workflow:

      # If a test failed the workflow exit with a failing status
      - name: Clean up
        if: ${{env.TESTS_FAILED == 'True'}}
        run: exit 1

but apparently it never triggers.
@rhaas80 rhaas80 added the bug Something isn't working label Mar 16, 2023
einsteintoolkit-updater pushed a commit that referenced this issue Sep 26, 2023
updated submodules
1a7e5ff 
Submodule repos/GRHayL 7d7c297..b2b281e:
  > bugfix with B in Newman1D
  > Rescaled B by factor of 1/sqrt(4pi) (#54)
Submodule repos/GRHayLET b89ba60..b6deb7f:
  > GRHayLID: removed unused variable
  > GRHayLMHD: change to GRHayL definition of B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhaas80