feat: allow proxy to run on multiple test environments #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
Allow proxy to run on multiple test environments.
Background 📜
Let's say that you have multiple test environments with different configurations, e.g.
RAILS_ENV=test
- unit testsRAILS_ENV=test_e2e
- end-to-end testsYou might want to be able to run the proxy server in each of these environments while developing or writing tests. With the current implementation of
run_proxy?
, theENV
name must match"test"
exactly for the proxy to run.The Fix 🔨
This PR contains a simple, but potentially hacky fix - instead of an exact match, we check if
mode
contains the substring "test". It's hacky becausemode
can be any arbitrary string, e.g."greatest_production"
, that might unintentionally match the condition.At the risk of bloat, a better way might be to add a config for it, let's say,
force_proxy
.Is there already a workaround for this? If not, what would be a suitable way to handle this? I'd be happy to see this PR through.
Screenshots 📷