Add logger as a runtime dependency rather than default gem
#502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default gem `logger` will be removed from Ruby 3.5.0 and must now be installed separately. This also resolves a warning in Ruby 3.3.5.
joeldrapper
commented
Oct 11, 2024
vite_ruby/vite_ruby.gemspec
Outdated
| @@ -21,6 +21,7 @@ Gem::Specification.new do |s| | |||
| s.add_dependency 'dry-cli', '>= 0.7', '< 2' | |||
| s.add_dependency 'rack-proxy', '~> 0.6', '>= 0.6.1' | |||
| s.add_dependency 'zeitwerk', '~> 2.2' | |||
| s.add_dependency 'logger', '~> 1.6' | |||
There was a problem hiding this comment.
I don’t know if vite_ruby actually depends on ~> 1.6 or if it would be happy with an older version of the gem. It looks like 1.6.1 does support Ruby versions back to 2.5.0 so there shouldn’t be any issues there.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
The default gem
loggerwill be removed from Ruby 3.5.0 and must now be installed separately. This also resolves a warning in Ruby 3.3.5.Background 📜
Ruby is removing some of the “default” gems so they now need to be installed separately.
The Fix 🔨
I’ve added the
loggergem as a runtime dependency.Screenshots 📷
I don’t have any screenshots, but I have a copy of the warning message in Ruby 3.3.5.