pset: Add input explicit value, assets, and proofs, and issuance blinding flag #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippem
reviewed
Sep 1, 2022
apoelstra
reviewed
Sep 6, 2022
apoelstra
reviewed
Sep 6, 2022
|
Done reviewing 902b736: Mostly just nits, except the |
achow101
force-pushed
the
explicit-pset-fields
branch
from
902b736
to
9ecbf38
Compare
apoelstra
approved these changes
Sep 6, 2022
gwillen
added a commit
to gwillen/elements
that referenced
this pull request
Mar 2, 2023
This was referenced Apr 20, 2024
Merged
apoelstra
added a commit
to ElementsProject/rust-elements
that referenced
this pull request
Apr 23, 2024
eb85a23 ci: cargo update cc (Leonardo Comandini) 6320c7c pset: input: add explicit amount and asset, and their proofs (Leonardo Comandini) Pull request description: They were added in ElementsProject/elements#1157 ACKs for top commit: apoelstra: ACK eb85a23 Tree-SHA512: f3126e66f210f0ee13f4d4751325f586ae8e35290791602a2066b3fe2b71914d51f2e012f20fed1ddd0690dc011586a8e1a6d115fc8815a959aff618f826486b
apoelstra
added a commit
to ElementsProject/rust-elements
that referenced
this pull request
Apr 23, 2024
908cb5e pset: input: merge: add missing fields (Leonardo Comandini) cd6ad48 pset: input: test issuance (Leonardo Comandini) 0453428 pset: input: handle blinded_issuance (Leonardo Comandini) 1bde7a1 pset: input: add blinded issuance flag (Leonardo Comandini) Pull request description: Added in ElementsProject/elements#1157 ACKs for top commit: apoelstra: ACK 908cb5e this looks good for now. Would be good to actually implement the blinding of course Tree-SHA512: 12039dcf0f68493cf959d84c64742b01367c847599c4960428f6813d9945933d526764e7787f8bb9836b34d217cb8a7d3003f38271ae79500dfc1b5477a720da
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fields for explicit input value and assets, and their proofs. Also adds a flag to indicate whether an issuance should be blinded.
Closes #1153