Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support for liquidtestnet #1167

Merged
merged 8 commits into from
Nov 23, 2022

Conversation

psgreco
Copy link
Contributor

@psgreco psgreco commented Sep 9, 2022

Currently using liquidtestnet requires a big config file, which is error-prone and uncomfortable for users, this MR adds support for just using -chain=liquidtestnet.

There are a few things that need to be discussed/addressed

  1. Main port (currently set to 18891 because that's the one used originally, and the one that's configured in liquidtestnet.com)
  2. RPC and extra ports, I just chose some non-overlapping ports that are "close" to the ones in the other liquid/elements networks.
  3. Icon color, I just used something different than liquidv1 and elementsregtest, suggestions accepted 😉
  4. liquid-testnet.blockstream.com is still using port 18892, it will be changed to 18891 soon.
  5. both seeds are just CNAME dns records at the moment, they should be changed to real seed nodes (no changes in code required, but important for review)

@delta1
Copy link
Member

delta1 commented Sep 9, 2022

adds support for just using -chain=elementsregtest

should this be -chain=liquidtestnet ?

@delta1
Copy link
Member

delta1 commented Sep 9, 2022

partially tested ACK 3ccccca

I compiled elementsd and ran it with -chain=liquidtestnet, the daemon connected and started synchronizing the liquid testnet block headers

@psgreco
Copy link
Contributor Author

psgreco commented Sep 9, 2022

adds support for just using -chain=elementsregtest

should this be -chain=liquidtestnet ?

Yes, fixed

@delta1
Copy link
Member

delta1 commented Sep 9, 2022

ACK c6e074e

Tested by compiling the codebase, started elementsd -chain=liquidtestnet sync, and started elements-qt -chain=liquidtestnet sync successfully

@wintercooled
Copy link
Contributor

ACK c6e074e

Compiled, installed and ran elements-qt with -chain=liquidtestnet and could sync to tip.

Note: I only tested running without -chain=liquidtestnet briefly - did not wait to sync live to tip.

@gwillen
Copy link
Contributor

gwillen commented Oct 24, 2022

utACK. My main concern is making sure there is absolutely no accidental behavior change for existing users of custom chains. (As far as I can tell there is not.)

@apoelstra
Copy link
Member

utACK c6e074e

@apoelstra apoelstra merged commit 1339dae into ElementsProject:master Nov 23, 2022
@psgreco psgreco deleted the master-liquidtestnet branch January 13, 2023 12:09
jamesdorfman added a commit to jamesdorfman/elements that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants