-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.17] don't do mac travis build, no support #428
Conversation
utACK |
last build appears to be failing for taking too long. Doubt it's our fault. |
Let's keep this open, but can't we leave it without merging for as long as we can? |
Why? You'd have to get the OSX image thing that's proprietary.
…On Fri, Oct 12, 2018, 8:15 PM Jorge Timón ***@***.***> wrote:
Let's keep this open, but can't we leave it without merging for as long as
we can?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#428 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFgC0wTqn_vARpqF1UMATVjc6bWfQUNyks5ukTC3gaJpZM4XZqcJ>
.
|
That is a very goo point, but isn't only travis who does got to get it? |
I guess my point and my vote is: let's keep as many tests from bitcoin core living for as long as we can until it is convenient for a given change to just ignore those tests for unsupported platforms. Yes we can run test for things we don't support. Perhaps what we really need is some doc:
Or something of the sort. |
My point is currently the test isn't living. If we can make it live later, great. Until then I'm disabling it. |
I'm not really seeing the problem. All 0.17 PRs seem to pass this build in CI.. |
oh hm it was failing before, and previous branches definitely didn't work. |
489060d qt: Do not show unused widgets at startup (Hennadii Stepanov) Pull request description: On master (8d83f9c), when starting without wallets the `labelWalletEncryptionIcon` and `labelWalletHDStatusIcon` widgets are not used but still visible as empty space: ![Screenshot from 2021-09-29 21-59-22](https://user-images.githubusercontent.com/32963518/135332107-f02db936-3c3a-436b-9e78-c5721df8852b.png) If one opens any wallet then closes it, the widget layout becomes densed: ![Screenshot from 2021-09-29 22-05-31](https://user-images.githubusercontent.com/32963518/135332650-83787bc4-fa8e-417e-8d53-a9fdb1c8bfc9.png) This PR makes widget layout densed at startup. Fixes ElementsProject#428. ACKs for top commit: jarolrod: ACK 489060d promag: Code review ACK 489060d. Tree-SHA512: bda7195225ecd203bb3269ebe7fc264aaf7f57b922deb83a04127584a5d6123950741fb431161523e84630927c2f617e85c085bbbe75ad8559da7b2947de1bdd
No description provided.