Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.17] don't do mac travis build, no support #428

Closed

Conversation

instagibbs
Copy link
Collaborator

No description provided.

@instagibbs instagibbs changed the title don't do mac travis build, no support [0.17] don't do mac travis build, no support Oct 12, 2018
@stevenroose
Copy link
Member

utACK

@instagibbs
Copy link
Collaborator Author

last build appears to be failing for taking too long. Doubt it's our fault.

@jtimon
Copy link
Contributor

jtimon commented Oct 13, 2018

Let's keep this open, but can't we leave it without merging for as long as we can?

@instagibbs
Copy link
Collaborator Author

instagibbs commented Oct 13, 2018 via email

@jtimon
Copy link
Contributor

jtimon commented Oct 13, 2018

That is a very goo point, but isn't only travis who does got to get it?

@jtimon
Copy link
Contributor

jtimon commented Oct 14, 2018

I guess my point and my vote is: let's keep as many tests from bitcoin core living for as long as we can until it is convenient for a given change to just ignore those tests for unsupported platforms. Yes we can run test for things we don't support. Perhaps what we really need is some doc:

WARNING: We don't plan to support this build and don't dream about signing it, but we will keep running tests with this piece of proprietary software just in case it burns differently in an interesting way.

Or something of the sort.

@instagibbs
Copy link
Collaborator Author

My point is currently the test isn't living. If we can make it live later, great. Until then I'm disabling it.

@stevenroose
Copy link
Member

I'm not really seeing the problem. All 0.17 PRs seem to pass this build in CI..

@instagibbs
Copy link
Collaborator Author

oh hm it was failing before, and previous branches definitely didn't work.

@instagibbs instagibbs closed this Oct 16, 2018
delta1 pushed a commit to delta1/elements that referenced this pull request Apr 28, 2023
489060d qt: Do not show unused widgets at startup (Hennadii Stepanov)

Pull request description:

  On master (8d83f9c), when starting without wallets the `labelWalletEncryptionIcon` and
  `labelWalletHDStatusIcon` widgets are not used but still visible as empty space:

  ![Screenshot from 2021-09-29 21-59-22](https://user-images.githubusercontent.com/32963518/135332107-f02db936-3c3a-436b-9e78-c5721df8852b.png)

  If one opens any wallet then closes it, the widget layout becomes densed:

  ![Screenshot from 2021-09-29 22-05-31](https://user-images.githubusercontent.com/32963518/135332650-83787bc4-fa8e-417e-8d53-a9fdb1c8bfc9.png)

  This PR makes widget layout densed at startup.

  Fixes ElementsProject#428.

ACKs for top commit:
  jarolrod:
    ACK 489060d
  promag:
    Code review ACK 489060d.

Tree-SHA512: bda7195225ecd203bb3269ebe7fc264aaf7f57b922deb83a04127584a5d6123950741fb431161523e84630927c2f617e85c085bbbe75ad8559da7b2947de1bdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants