Code

[0.17, WIP] Confidential Assets#503

Code

Closed

stevenroose wants to merge 229 commits intoElementsProject:elements-0.17ElementsProject/elements:elements-0.17from stevenroose:e17-castevenroose/elements:e17-caCopy head branch name to clipboard

+11,730-1,926

Commits

Commits on Feb 14, 2019

• WIP: squashed CA work

  stevenroose

  committed
  b12b334

• Add missing test case files

  

  instagibbs

  authored and

  stevenroose

  committed
  f1e0908

• WIP: rebase fixes

  stevenroose

  committed
  bfed763

• cherrypick unblindrawtransaction commit from 0.14

  stevenroose

  committed
  5bc6604

Commits on Feb 15, 2019

• assets in tests

  stevenroose

  committed
  e32b057

Commits on Feb 19, 2019

• fixups

  stevenroose

  committed
  7f28284

• REMOVEME: add print statements

  stevenroose

  committed
  a04cb01

Commits on Feb 20, 2019

• Replace CScriptID and CKeyID in CTxDestination with dedicated type

  instagibbs

  committed
  caeacf8

• fixups

  stevenroose

  committed
  5b05e8b

• fixups

  stevenroose

  committed
  b2abf9a

• REMOVEME: more printing

  stevenroose

  committed
  ee55bab

Commits on Feb 21, 2019

• WIP: Coin selection

  stevenroose

  committed
  ab12320

Commits on Feb 22, 2019

• REMOVEME: printing

  stevenroose

  committed
  050894a

• WIP

  stevenroose

  committed
  9da884a

• REMOVEME: printing

  stevenroose

  committed
  2447e69

• bitcoin_functional working

  stevenroose

  committed
  ab00a4e

Commits on Feb 23, 2019

• Add BITCOIN_ASSET to all occurrences of getbalance()

  stevenroose

  committed
  cd98ff6

• Make balance responses always contain at least policyAsset

  stevenroose

  committed
  fac4f53

Commits on Feb 25, 2019

• REMOVEME: printing

  stevenroose

  committed
  35e4dea

• REMOVEME: printing

  stevenroose

  committed
  b12d763

• f'Add BITCOIN_ASSET to all occurrences of getbalance()'

  stevenroose

  committed
  e91591a

• random fixups

  stevenroose

  committed
  1226d63

• changekey thing

  stevenroose

  committed
  3da00c1

• fix some change position tracking

  stevenroose

  committed
  a56b817

Commits on Feb 26, 2019

• Don't allow fees in coinbase transactions

  stevenroose

  committed
  1c898a9

• f'Add BITCOIN_ASSET to all occurrences of getbalance()'

  stevenroose

  committed
  6019152

• fixes

  stevenroose

  committed
  024993e

• SHash to ScriptHash to reflect upstream changes

  instagibbs

  committed
  ab323c5

• add blinding pubkey to relevant destinations

  instagibbs

  committed
  3d00250

Commits on Feb 27, 2019

• Initialize master blinding derivation key on wallet load if uninitialized

  instagibbs

  committed
  3f0a5c1

• Encoding and decoding of blinded addresses, getnewaddress support

  instagibbs

  committed
  fa84698

• Add fee outputs to functional tests

  stevenroose

  committed
  e350d95

• f'Add BITCOIN_ASSET to all occurrences of getbalance()'

  stevenroose

  committed
  5eb4703

• Fix hard-coded tx in functional test

  stevenroose

  committed
  b07454d

• Disable tests that are not relevant for Elements

  stevenroose

  committed
  ba2e137

• fix coin selection

  stevenroose

  committed
  a6275e5

• f'Disable tests that are not relevant for Elements'

  stevenroose

  committed
  b7838a6

• coin selection fixups

  stevenroose

  committed
  d208bc1

• disabled bech32 CT addresses for now

  instagibbs

  committed
  7a54504

• Add blinded address introspection in getaddressinfo and validateaddress

  instagibbs

  committed
  b5f45d6

• listunspent support for asset details, filtering

  instagibbs

  committed
  33a5bef

• getrawchangeaddress blinding

  instagibbs

  committed
  ecadc4b

• SendMoney: extract blinding key from destination

  instagibbs

  committed
  34b3ed2

• sendmany: add confidential key to receipients

  instagibbs

  committed
  418215e

• maybe support listreceivedby*, labels included?

  instagibbs

  committed
  dd11388

• Fee outputs only exist in elements mode

  instagibbs

  committed
  81334ec

• listtransactions: support assets

  instagibbs

  committed
  ef1e8b6

• cleanup fee for bitcoind mode in listtransaction

  instagibbs

  committed
  883b0be

• getpeginaddress: no need to get unblinded version of address

  instagibbs

  committed
  47eeab4

• Load pet asset labels from conf file and command line

  instagibbs

  committed
  b88d672

• move asset args to init.cpp

  instagibbs

  committed
  72d17c8

• add dumpassetlabels

  instagibbs

  committed
  b66224e

• import(issuance)blindingkey rpc calls

  instagibbs

  committed
  578c931

• Move all elements rpc json parsing in rpc/client.cpp to end, add a bunch of missing ones

  instagibbs

  committed
  ddfe8c7

• add TODO for importing master blinding key

  instagibbs

  committed
  c59a2f7

Commits on Feb 28, 2019

• dump(issuance)blindingkey

  instagibbs

  committed
  016fed1

• raw(re)issueasset

  instagibbs

  committed
  f8496ee

• fixups

  stevenroose

  committed
  b8ebef9

• f'Add BITCOIN_ASSET to all occurrences of getbalance()'

  stevenroose

  committed
  49121db

• REMOVEME: printing

  stevenroose

  committed
  4eae8f0

• (re)issueasset, listissuances calls

  instagibbs

  committed
  1ddcb27

• createblindedaddress RPC call

  instagibbs

  committed
  a08dbe3

• fixes

  stevenroose

  committed
  380ce79

• fixup find_vout_for_address with confidential addresses

  instagibbs

  committed
  0ae575a

Commits on Mar 1, 2019

• f'Add BITCOIN_ASSET to all occurrences of getbalance()'

  stevenroose

  committed
  d06ebfb

• fixing tests

  stevenroose

  committed
  c370f19

• AmountMapToUniv

  stevenroose

  committed
  841d146

• AmountMapToUni to rpc/util.*

  instagibbs

  committed
  e349775

• Move PrintAmountMap back and add necessary includes in rpc/util.cpp

  instagibbs

  committed
  f9b94ff

• Add blech32 python implementation with diff annotation with segwit_addr.py

  instagibbs

  committed
  3cad894

• Add blech32 cpp implementation and API

  instagibbs

  committed
  b31ca8a

• fix blech32 decoding

  instagibbs

  committed
  82dfa2b

• Fix non-bech32 CT addresses

  instagibbs

  committed
  c6d7441

• Implement blech32 addresses, expose over RPC

  instagibbs

  committed
  4841db0

• fixes

  stevenroose

  committed
  ac89d18

• test fixes

  stevenroose

  committed
  9e834fe

• blech32 support in chains/coders

  instagibbs

  committed
  9c18bb6

• blech32: grab right pubkey bytes

  instagibbs

  committed
  7f80448

• Finish getaddressinfo fetch of confidential address types

  instagibbs

  committed
  900189d

• p2p_invalid.py: Add fee outputs

  instagibbs

  committed
  5a49efd

• fix create_transaction, feature_cltv.py

  instagibbs

  committed
  d63ea79

• fix feature_dersig.py

  instagibbs

  committed
  f8ead4a

• fix feature_nulldummy.py

  instagibbs

  committed
  8f15803

• still not fixed: feature_csv_activation.py

  instagibbs

  committed
  7ed6eeb

Commits on Mar 4, 2019

• Fix feature_block.py

  stevenroose

  committed
  8f8d557

• Update rpc_getblockstats test data

  stevenroose

  committed
  fb04f16

• fixes

  stevenroose

  committed
  4f3fdbb

• fix rbf test

  instagibbs

  committed
  2fcd64b

• fix feature_block_v4.py

  instagibbs

  committed
  8465114

• importmulti: add blinding_privkey arg, fix test

  instagibbs

  committed
  6fa770f

• nit

  stevenroose

  committed
  bb42f3b

• segwit test fix

  stevenroose

  committed
  0a1bb87

• Fix wallet compatibility mode

  instagibbs

  committed
  bcf9ab3

• fixes

  stevenroose

  committed
  ade61d6

• Rename IssuanceDetails->RawIssuanceDetails, make wallet version

  instagibbs

  committed
  6a74846

• Add DEFAULT_RANGEPROOF_SIZE constant, test

  instagibbs

  committed
  7f98912

• p2p_segwit

  stevenroose

  committed
  cd207e9

Commits on Mar 5, 2019

• Stick fee output in end with createrawtransaction, fix bumpfee test non-determinism

  instagibbs

  committed
  f528177

• Make sure wallet makes change for bumpfee

  instagibbs

  committed
  4250cdd

• checkin blinding sends using CreateTransaction

  instagibbs

  committed
  e8725a9

• fixup CreateTransaction and add assert in GetBlindingData

  instagibbs

  committed
  7f343e7

• Wipe blinding data for CWalletTx that are being bumped

  instagibbs

  committed
  4534f51

• fee output cleanup

  stevenroose

  committed
  d912696

• Fix benchmarks

  stevenroose

  committed
  6b51175

• Add valueFor method

  stevenroose

  committed
  d9cd258

• Fix Qt build

  stevenroose

  committed
  c482b48

• WIP: porting CA tests from 0.14.1

  stevenroose

  committed
  a8641fe

Commits on Mar 6, 2019

• snipe elements pull#480

  instagibbs

  committed
  384f73e

• snipe elements pull#472

  instagibbs

  committed
  8e6b3c4

• importblindingkey support for master blinding key

  instagibbs

  committed
  8b0099c

• fixup unit test json response for CA

  instagibbs

  committed
  d4e3a77

• Add secure reporting document, link in README

  instagibbs

  committed
  094bcce

• fixups

  stevenroose

  committed
  382e541

• check-in issuing and blinding CreateTransaction stuff

  

  instagibbs

  authored and

  stevenroose

  committed
  3672f41

• WIP issuance blinding

  stevenroose

  committed
  323924c

Commits on Mar 7, 2019

• blinding fixups, compiles but crashes

  stevenroose

  committed
  c6475c7

• fix (re)issueasset segfault, add more logging

  instagibbs

  committed
  f94a845

• Preserve issuance and input ordering by not wiping inputs

  instagibbs

  committed
  beb4e41

• remove old checks, normalize witness vectors in CreateTransaction

  instagibbs

  committed
  765f78d

• Blinding during issuance working... which breaks everything :)

  instagibbs

  committed
  1faa171

• move more asset detailing into fillBlinds, stop double-counting asset type

  instagibbs

  committed
  6fbb69b

• Mark GetAmount locations post-tx-blinding

  instagibbs

  committed
  d777de0

• Make MutableTransactionSignatureCreator constructor explicit to avoid implicit value conversion

  instagibbs

  committed
  7e1d915

• derp, comments

  instagibbs

  committed
  9cabaa6

• Commented out transaction rebalancing, fixme steven

  instagibbs

  committed
  9af11f2

Commits on Mar 8, 2019

• Avoid calling GetAmount and GetAsset in CWallet code

  stevenroose

  committed
  abae40c

• fixups

  stevenroose

  committed
  ce925d3

• REMOVEME: prints

  stevenroose

  committed
  59a0010

• REMOVEME: remove prints

  stevenroose

  committed
  8aa4473

• fixups

  stevenroose

  committed
  98c0346

• issuance test fixups

  stevenroose

  committed
  bb39910

• panic fix

  stevenroose

  committed
  5bfecc0

• test fixup

  stevenroose

  committed
  be7280b

• destroyamount

  stevenroose

  committed
  6eba7c4

• we aren't doing audit log anymore

  instagibbs

  committed
  b7e2eb9

Commits on Mar 11, 2019

• f

  stevenroose

  committed
  14684f8

• Wipe o_*_blinds between different blindings

  instagibbs

  committed
  30843d2

• fixup

  instagibbs

  committed
  0827cf5

• print + fix

  stevenroose

  committed
  5747d21

• REMOVEME: printing

  stevenroose

  committed
  2aa6570

• fixups

  stevenroose

  committed
  9606f53

• fixups

  stevenroose

  committed
  ff60ae9

• fixed only recipient field in CreateTransaction

  instagibbs

  committed
  36e44ce

• fix

  stevenroose

  committed
  424d27c

• Don't use effective_value for unblinded value

  stevenroose

  committed
  e3eac42

• fix

  stevenroose

  committed
  7ad54a9

• CreateTransaction: Wipe all witness data in loop as well

  instagibbs

  committed
  2fae6f1

Commits on Mar 12, 2019

• fixes

  stevenroose

  committed
  bb95103

• REMOVEME: printing

  stevenroose

  committed
  62c7e02

• test fix

  stevenroose

  committed
  c9bcb0e

• Fixup createraw/fundraw blinding key, print more in decode

  instagibbs

  committed
  3c98fdb

• feature_issuance.py: fund transactions more to not miss min relay with large issuances

  instagibbs

  committed
  1025164

• no panic: explicit was already filtered for

  instagibbs

  committed
  0bf76fd

• listunspent: always return asset regardless of commitment type

  instagibbs

  committed
  0458f96

• Add rangeproof details to raw tx output

  instagibbs

  committed
  2b93e5a

• fix createrawtransaction arguments for elements

  instagibbs

  committed
  4f6cdfb

• fixup sendtoaddress help, re-enable ignoreblindfail for sendmany

  instagibbs

  committed
  09dc8e2

• finish fixing feature_issuance.py

  instagibbs

  committed
  7bc8054

• add feature_issuance to test_runner

  instagibbs

  committed
  48d635e

• fix default_asset_name.py and add to test_runner

  instagibbs

  committed
  5e1f82d

Commits on Mar 13, 2019

• test fixes

  stevenroose

  committed
  8ffdb60

• fixes

  stevenroose

  committed
  b09c05f

• fundraw with blinding

  stevenroose

  committed
  1907bb8

• no coinbase fees

  stevenroose

  committed
  917a3fc

• copied confidential test

  stevenroose

  committed
  bafa371

• WIP: confidential_transactions test

  stevenroose

  committed
  3c3c4d6

• Compare block and utxo db outputs correctly

  instagibbs

  committed
  3bb1b0b

• ASK SIPA: disable sanity check with legacy txo db when connecting gen outputs

  instagibbs

  committed
  8779a7a

• Fix fundraw with blinded destinations

  instagibbs

  committed
  5466aa6

• Add some logging on transaction modification due to blinding edge cases

  instagibbs

  committed
  4812ec9

• fix fundrawtransaction test

  instagibbs

  committed
  e23eaab

• fix default asset name test name

  instagibbs

  committed
  aaf730b

• fixup default asset name

  instagibbs

  committed
  d15f121

• fixup elements json results tests one more time

  instagibbs

  committed
  60d2e5d

• fundraw needs to preserve sequence numbers when in blinding mode

  instagibbs

  committed
  b413d04

• Fix fundraw assert in compatibility mode

  instagibbs

  committed
  bf1abc9

• fix feature_assetdir.py

  instagibbs

  committed
  92c6a3b

• feature_fee_estimation: change constants to have it not time out

  instagibbs

  committed
  d80009d

• re-add reissuance test

  instagibbs

  committed
  632b54a

• Add test diagnosing help in feature_issuance.py for failures

  instagibbs

  committed
  b5616c1

• fixing confidential_transactions

  stevenroose

  committed
  f07227c

Commits on Mar 14, 2019

• feature_confidential_transactions works!

  stevenroose

  committed
  7c4ebd3

• set blinding fail in SendMoney

  instagibbs

  committed
  6d4d130

• Fix credit accounting when outputs can't be unblinded

  instagibbs

  committed
  5ad5afd

• Actually test blinded multisig issuance

  instagibbs

  committed
  09cd1ce

• no need to include watching

  instagibbs

  committed
  2f86b72

• unblinding checks

  stevenroose

  committed
  5b6ecde

• assert GetCredit and add feature_ct to runner

  stevenroose

  committed
  8621d3b

• signrawtransactionwith* support signing with prevtxs when given

  instagibbs

  committed
  4c83d43

• address TODOs

  stevenroose

  committed
  c8b84d7

• balance stuff fix :|

  stevenroose

  committed
  4eb6b21

• WIP: per-asset change script

  stevenroose

  committed
  24ef3a0

• GetTransactionInputWeight: only used for change spend size, assert expected conditions

  instagibbs

  committed
  41cda38

• listunspent filter available coins by asset up front for min/max val args

  instagibbs

  committed
  5549008

• Leave note on wallet dust calculation

  instagibbs

  committed
  7b30d0d

• Don't allow encoded empty witnesses

  instagibbs

  committed
  4a6e555

• don't access null output info

  instagibbs

  committed
  c17c0fa

Commits on Mar 15, 2019

• WIP (compiles): change destinations

  stevenroose

  committed
  5edb90f

• finish change script

  stevenroose

  committed
  2d4317e

• proposal liquidv1 chainparams

  instagibbs

  committed
  ef3ab0e

• remove coinbase validation printing

  instagibbs

  committed
  2dce5d8

• f'proposal liquidv1 chainparams'

  instagibbs

  committed
  d14a0cb

• blinded addresses

  stevenroose

  committed
  5caad05

• remove more printing in validation

  instagibbs

  committed
  d3d9cd6

• fix liquidv1 addresses

  instagibbs

  committed
  303c911

• change genesis block creation

  stevenroose

  committed
  7a1252b

• add liquidv1 genesis hash assertion

  stevenroose

  committed
  b8f57a7

• use the right liquidv1 magic.... not liquid beta

  instagibbs

  committed
  257695b

• Segwit deployed block 0 in liquidv1

  instagibbs

  committed
  5275d55

• Fix witness merkle root for elements

  instagibbs

  committed
  3026d60

• liquid fedpegscript matching fixup

  instagibbs

  committed
  1402221

• report peg-in error message

  instagibbs

  committed
  8cb0e32

Commits on Mar 16, 2019

• Don't tweak watchman emergency pubkeys

  instagibbs

  committed
  c4c5f2a

• calculate_contract needs to continue to end

  instagibbs

  committed
  532a47d

• Sighashing should cover issuance inputs...

  instagibbs

  committed
  6e69f56

Commits on Mar 17, 2019

• Sanity check fedpegscript on init

  instagibbs

  committed
  77217d2

• alignment

  instagibbs

  committed
  0575a4f

Commits on Mar 18, 2019

• remove unneeded level of indentation

  stevenroose

  committed
  ce99524

• Properly create witness merkle root for elements

  instagibbs

  committed
  5d13ead

• Elaborate more on witness merkle

  instagibbs

  committed
  aafb120

• witness hash fix in python functional tests

  stevenroose

  committed
  16acc5b

• fix a bit of p2p_segwit.py

  instagibbs

  committed
  93a4a63

• Print more during witness commitment validation

  instagibbs

  committed
  ea68772

Commits on Mar 19, 2019

• Switch witness merkle root to handle bitcoin print hashes as strings, handle results after

  instagibbs

  committed
  2fa5e39

• fix prevout.isNull calculation

  instagibbs

  committed
  cb160ea

• sighash issuance

  stevenroose

  committed
  bea789d

• hashIssuance requires all inputs' data

  instagibbs

  committed
  d4b3c1c

• missed calc_withess_hash call

  instagibbs

  committed
  215f336

• getblockstats

  stevenroose

  committed
  a91e8fc