[0.17] Cleaned up CA #515
Merged
[0.17] Cleaned up CA #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will have effect on more than just witness structure from now on.
instagibbs
force-pushed
the
e17-ca-clean
branch
from
434734c to
0148024
Compare
instagibbs
force-pushed
the
e17-ca-clean
branch
from
d2984e4 to
665d9eb
Compare
|
Currently having two unexpected failures. One is debug build and consistent, will try to reproduce locally. The other is simply taking too long during functional testing. I imagine this is the fee estimation test which takes quite a while even on more powerful machines. |
stevenroose
added a commit
that referenced
this pull request
Mar 20, 2019
ac64280 Set correct ports for Liquid network params (Steven Roose) 6491b4d Use upstream Shuffle which doesn't cause DEBUG panic (Gregory Sanders) de56cd8 move fee estimation test to extended tests, takes too long (Gregory Sanders) 1f062da Fix compilation of certain builds (Gregory Sanders) 7d86c7d remove leftover asset debug printing (Gregory Sanders) 1fec77f Add elements transaction unit test data to EXTRA_DIST (Gregory Sanders) 665d9eb Whitespace and tab linting (Gregory Sanders) 3055245 Spelling linter (Gregory Sanders) 0148024 Functional test linting (Gregory Sanders) 242515f LogPrints need \n (Gregory Sanders) b4c9ccb remove duplicate includes in test_bitcoin (Gregory Sanders) 8371cfc Fixup blind.h guard (Gregory Sanders) bc9a610 Fixup wallet log print (Gregory Sanders) f56de12 Remove all but one circular dep: coinselection <-> wallet (Gregory Sanders) 5c3481a Lint RPC args (Gregory Sanders) 04a8f2e Document blindedprefix arg (Gregory Sanders) a687dd9 Add assets and issuance functional tests (Steven Roose) 96af43b Add confidential transactions functional test (Steven Roose) 39020cd Adapt existing functional tests to CA (Steven Roose) 6113bf8 [BROKEN] Add fee outputs to functional tests (Steven Roose) b48aea8 [BROKEN] Account for assets in all balance inspection in tests (Steven Roose) 43f8b45 [BROKEN] Adapt bitcoin_functional tests to CA (Steven Roose) 5f9f578 [BROKEN] Unbreak Qt code after CA (Steven Roose) f7920d7 [BROKEN] Add issuance wallet RPCs (Steven Roose) a361dda [BROKEN] Add CA wallet RPCs (Steven Roose) b6397d6 [BROKEN] Adapt wallet unit tests to CA (Steven Roose) d3ab44d [BROKEN] Adapt wallet to CA (Steven Roose) 49e8083 [BROKEN] Add raw issuance RPCs (Steven Roose) a03239d [BROKEN] Add raw tx RPCs for CA (Steven Roose) 6038c37 [BROKEN] Add unit test for blinding logic (Steven Roose) aa33202 [BROKEN] Add blinding logic (Steven Roose) cd56626 [BROKEN] Adapt existing unit tests to CA (Steven Roose) f4553d4 [BROKEN] Adapt existing benchmarks to CA (Steven Roose) 703db5b [BROKEN] Adapt existing RPCs to CA (Steven Roose) 6493ad9 Adapt bitcoin-tx to CA (Steven Roose) 0b50661 [BROKEN] Add CA validation (Steven Roose) d53479c [BROKEN] Introduce CA in data structures (Steven Roose) 04d0691 Rename con_elementswitness to con_elementsmode (Steven Roose) 484d83c Add new arguments (Steven Roose) fde9fe1 Add basic issuance boilerplate (Steven Roose) f81122f Add asset and value blinding functionality (Steven Roose) 8b8256d Add ConfidentialCommitment-based types (Steven Roose) d0322f7 Add initial issuance boilerplate (Steven Roose) fd411bb Enable surjection proof module in secp256k1-zkp (Steven Roose) 84954c8 Add CAssetsDir (Steven Roose) 10773c6 Add CAsset and CAmountMap (Steven Roose) 14af0b6 Implement blech32 addresses, expose over RPC (Gregory Sanders) 0f28780 Add blech32 implementation and API (Steven Roose) 9cb2fa0 Add blech32 python implementation with diff annotation with segwit_addr.py (Gregory Sanders) 17a22f1 Add support for blinded addresses (Steven Roose) 00fba77 Add liquidv1 chainparams (Gregory Sanders) 045e615 Add CKey::ECDH (Steven Roose) aa375e6 Replace CScriptID and CKeyID in CTxDestination with dedicated type (Gregory Sanders) 3e7cff1 Disable tests that are not relevant for Elements (Steven Roose) 3a0b3b7 Add tweakfedpeg and compatbility test (Gregory Sanders) 36a5d5d Fix bug in calculate_contract for Liquid (Steven Roose) 77ba5ee RPC params convertion cleanup (Steven Roose) ce19a5f Add secure reporting document, link in README (Gregory Sanders) Pull request description: Cleaned up version of #503. Tree-SHA512: fb82a182a49384dd4be5838c147f6049f3b554f6d861681df46d83819c39c460b469cb68a8f6c47a2e8d3c17e439fea8818f8bca03b200027e6a127875376892
instagibbs
added a commit
that referenced
this pull request
Mar 21, 2019
a657da0 Validation: stop logging fake pow data (Sjors Provoost) Pull request description: Based on #515. Backport of Blockstream/liquid#8 Tree-SHA512: 0f81430ca9905c4aa9b9e50ee3cd5a856132cc641dbc3346f982c2d5a023ab83cf68b64a3008f1adbda52d277d4357ed2d89e8ed6335c6288294fe5275743ba0
instagibbs
added a commit
that referenced
this pull request
Mar 21, 2019
5b8c79a Fix progress reporting issue (Steven Roose) Pull request description: Based on #515 Reimplementation of Blockstream/liquid#6 Tree-SHA512: 292be614802d0ca74bc9a19080bce46812bc4d5c386ed01f87e74898830946276359100d404868dda8fd4b4087699a9be804370a8ad387c7d92f4a3f5572d0b0
AkioNak
added a commit
to AkioNak/elements
that referenced
this pull request
May 16, 2019
In ElementsProject#515, the assetlabel has been added to two rpc command (getreceivedbyaddress and getreceivedbylabel) as the 3rd param. So this patch makes there rpc command accept the 3rd param.
AkioNak
added a commit
to AkioNak/elements
that referenced
this pull request
May 20, 2019
In ElementsProject#515, the assetlabel has been added to two rpc command (getreceivedbyaddress and getreceivedbylabel) as the 3rd param. So this patch makes there rpc command accept the 3rd param.
AkioNak
added a commit
to AkioNak/elements
that referenced
this pull request
Jun 3, 2019
In ElementsProject#515, the assetlabel has been added to two rpc command (getreceivedbyaddress and getreceivedbylabel) as the 3rd param. So this patch makes there rpc command accept the 3rd param.
AkioNak
added a commit
to AkioNak/elements
that referenced
this pull request
Jun 5, 2019
In ElementsProject#515, the assetlabel has been added to two rpc command (getreceivedbyaddress and getreceivedbylabel) as the 3rd param. So this patch makes there rpc command accept the 3rd param.
jtimon
pushed a commit
to jtimon/elements
that referenced
this pull request
Jun 7, 2019
53ad841 Add explanation about how BIP32 unhardened derivation can be used to simplify whitelisting 71c5fe0 Add comment to explain effect of max_n_iterations in surjectionproof_init 85fd42f add unit test for generator and pedersen commitment roundtripping 2ccf885 rangeproof: fix serialization of pedersen commintments 60c173b rangeproof: verify correctness of pedersen commitments when parsing 32d7526 generator: verify correctness of point when parsing ae14e8a rangeproof: check that points deserialize correctly when verifying rangeproof 44fe43d rangeproof: add fixed vector test case e065d7d Expose generator in shared library fb1ba32 fix spelling in documentation fb75faa Test for rejection of trailing bytes in range proofs 9b2cf17 Test for rejection of trailing bytes in surjection proofs a3a1800 Reject surjection proofs with trailing garbage 0c77ae9 Minor bugfix. Wrong length due to NUL character. b1f31bc Add whitelisting benchmark 52a9f8f add whitelist_impl.h to include for dist a707865 generator: add API tests ec1ef04 generator: remove unnecessary ARG_CHECK from generate() b0e9aa8 Fix generator makefile 526c654 Fix pedersen_blind_generator_blind_sum return value documentation b51886e Add n_keys argument to whitelist_verify 37c57de Fix checks of whitelist serialize/parse arguments 9b8a9d9 whitelist: fix serialize/parse API to take serialized length 7f17515 Fix include/secp256k1_rangeproof.h function argument documentation. 0d81702 rangeproof: add API tests 417bb06 surjectionproof: rename unit test functions to be more consistent with other modules 1e2d5c1 surjectionproof: add API unit tests 7878a29 surjectionproof: tests_impl.h s/assert/CHECK/g e609591 rangeproof: fix memory leak in unit tests 0c17f79 add surjection proof module c174f0c Implement ring-signature based whitelist delegation scheme a2bc660 rangeproof: several API changes 21bfb3c Expose generator in pedersen/rangeproof API f4620de Constant-time generator module d46fc3c rangeproof: expose sidechannel message field in the signing API cf40b1b [RANGEPROOF BREAK] Use quadratic residue for tie break and modularity cleanup 6d28767 Get rid of precomputed H tables (Pieter Wuille) ae1e576 Pedersen commitments, borromean ring signatures, and ZK range proofs. efc61dc Add 64-bit integer utilities e34ceb3 Merge ElementsProject#557: Eliminate scratch memory used when generating contexts b3bf5f9 ecmult_impl: expand comment to explain how effective affine interacts with everything efa783f Store z-ratios in the 'x' coord they'll recover ffd3b34 add `secp256k1_ge_set_all_gej_var` test which deals with many infinite points 84740ac ecmult_impl: save one fe_inv_var 4704527 ecmult_impl: eliminate scratch memory used when generating context 7f7a2ed ecmult_gen_impl: eliminate scratch memory used when generating context 314a61d Merge ElementsProject#553: add static context object which has no capabilities 1086fda Merge ElementsProject#354: [ECDH API change] Support custom hash function 40fde61 prevent attempts to modify `secp256k1_context_no_precomp` ed7c084 add static context object which has no capabilities 1e6f1f5 Merge ElementsProject#529: fix tests.c in the count == 0 case c8fbc3c [ECDH API change] Allow pass arbitrary data to hash function b00be65 [ECDH API change] Support custom hash function 95e99f1 fix tests.c in the count == 0 case 452d8e4 Merge ElementsProject#523: scratch: add stack frame support 6fe5043 scratch: add stack frame support 9bc2e26 Merge ElementsProject#522: parameterize ecmult_const over input size 7c1b91b parameterize ecmult_const over input size dbc3ddd Merge ElementsProject#513: Increase sparsity of pippenger fixed window naf representation fb9271d Merge ElementsProject#510: add a couple missing `const`s to ecmult_pippenger_wnaf cd5f602 Merge ElementsProject#515: Fix typo 09146ae Merge ElementsProject#512: secp256k1_ec_privkey_negate - fix documentation ec0a7b3 Don't touch leading zeros in wnaf_fixed. 9e36d1b Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar. 96f68a0 Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros. 9b7c47a Fix typo 6dbb007 Increase sparsity of pippenger fixed window naf representation 1646ace secp256k1_ec_privkey_negate - fix documentation 9b3ff03 add a couple missing `const`s to ecmult_pippenger_wnaf cd329db Merge ElementsProject#460: [build] Update ax_jni_include_dir.m4 macro 7f9c1a1 Merge ElementsProject#498: tests: Avoid calling fclose(...) with an invalid argument f99aa8d Merge ElementsProject#499: tests: Make sure we get the requested number of bytes from /dev/urandom b549d3d Merge ElementsProject#472: [build] Set --enable-jni to no by default instead of auto. d333521 Merge ElementsProject#494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS 2ef8ea5 Merge ElementsProject#495: Add bench_ecmult to .gitignore 82a96e4 tests: Make sure we get the requested number of bytes from /dev/urandom 5aae5b5 Avoid calling fclose(...) with an invalid argument cb32940 Add bench_ecmult to .gitignore 31abd3a Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS c95f6f1 Merge ElementsProject#487: fix tests typo, s/changed/unchanged fb46c83 Merge ElementsProject#463: Reduce usage of hardcoded size constants 02f5001 Merge ElementsProject#490: Disambiguate bench functions and types 1f46d60 Disambiguate bench functions and types f54c6c5 Merge ElementsProject#480: Enable benchmark building by default c77fc08 Merge ElementsProject#486: Add pippenger_wnaf for multi-multiplication d2f9c6b Use more precise pippenger bucket windows 4c950bb Save some additions per window in _pippenger_wnaf a58f543 Add flags for choosing algorithm in ecmult_multi benchmark 36b22c9 Use scratch space dependent batching in ecmult_multi 355a38f Add pippenger_wnaf ecmult_multi bc65aa7 Add bench_ecmult dba5471 Add ecmult_multi tests 8c1c831 Generalize Strauss to support multiple points 548de42 add resizeable scratch space API 0e96cdc fix typo, s/changed/unchanged c7680e5 Reduce usage of hardcoded size constants 6ad5cdb Merge ElementsProject#479: Get rid of reserved _t in type names 7a78f60 Print whether we're building benchmarks 4afec9f Build benchmarks by default d1dc9df Get rid of reserved _t in type names 57752d2 [build] Set --enable-jni to no by default instead of auto. e7daa9b [build] Tweak JNI macro to warn instead of error for JNI not found. 5b22977 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS git-subtree-dir: src/secp256k1 git-subtree-split: 53ad841cafa3bcb94b65409aec91fd7043533cf7
stevenroose
added a commit
that referenced
this pull request
Jul 1, 2019
7b0b52f [RPC]Add assetlabel support to some commands (Akio Nakamura) Pull request description: The support of assetlabel parameter that was previously present left behind from elements-0.17 when #515 have been merged. I think it is still useful for these commands to support assetlabels. This patch add assetlabel support to following RPC: 1. getreceivedbyaddress Add the 3rd parameter as "assetlabel" Print 'optional' explicitly in the help text.↲ 2. getreceivedbylabel Add the 3rd parameter as "assetlabel" Print 'optional' explicitly in the help text.↲ 3. gettransaction Add the 3rd parameter as "assetlabel" 4. getbalance Set the name of 4th parameter as "assetlabel". Print 'optional' explicitly in the help text.↲ 5. listreceivedbyaddress Set the name of 5th parameter as "assetlabel". Enable assetlabel selection to the result of amounts. Print 'optional' explicitly in the help text.↲ 6. sendtoaddress Print 'optional' explicitly in the help text.↲ ... and add some tests for assetlabel support. notice) Also ```getwalletinfo``` had a parameter to specify "assetlabel". But no need to add a parameter because the command is a catch-all one. Tree-SHA512: ba8633e87e21ea3ae5f16f30eb3767e79d7b52cf0ada73257f71416ece2eeca91566e6d33d00bcb8efeac6012def8d3c86bb39deb0fc6a54b24758b8d469e1ef
gwillen
pushed a commit
that referenced
this pull request
Feb 27, 2021
b19c000063 Merge #607: Use size_t shifts when computing a size_t 4d01bc2d9c Merge #606: travis: Remove unused sudo:false e6d01e9347 Use size_t shifts when computing a size_t 7667532bd7 travis: Remove unused sudo:false ee99f12f3d Merge #599: Switch x86_64 asm to use "i" instead of "n" for immediate values. d58bc93f2c Switch x86_64 asm to use "i" instead of "n" for immediate values. 05362ee042 Merge #597: Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build 83483869ac Add $(COMMON_LIB) to exhaustive tests to fix ARM asm build aa15154a48 Merge #568: Fix integer overflow in ecmult_multi_var when n is large 2277af5ff0 Fix integer overflow in ecmult_multi_var when n is large 85d0e1bcce Merge #591: Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing. 14196379ec Merge #580: Add trivial ecmult_multi algorithm which does not require a scratch space a697d82da9 Add trivial ecmult_multi to the benchmark tool bade617417 Add trivial ecmult_multi algorithm. It is selected when no scratch space is given and just multiplies and adds the points. 5545e13dea Merge #584: configure: Use CFLAGS_FOR_BUILD when checking native compiler 20c5869df2 Merge #516: improvements to random seed in src/tests.c b76e45d5d6 Make bench_internal obey secp256k1_fe_sqrt's contract wrt aliasing. 870a977644 Merge #562: Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse be40c4d0b5 Fixup for C90 mixed declarations. c71dd2c08f Merge #509: Fix algorithm selection in bench_ecmult 6492bf88cc Merge #518: Summarize build options after running configure 0e9ada1941 Merge #567: Correct order of libs returned on pkg-config --libs --static libsecp2… e96901a4b9 Merge #587: Make randomization of a non-signing context a noop 58df8d03ad Merge #511: Portability fix for the configure scripts generated 2ebdad772a Merge #552: Make constants static: 1c131affd3 Merge #551: secp256k1_fe_sqrt: Verify that the arguments don't alias. ba698f883b Merge #539: Assorted minor corrections 949e85b009 Merge #550: Optimize secp256k1_fe_normalize_weak calls. a34bcaadf1 Actually pass CFLAGS_FOR_BUILD and LDFLAGS_FOR_BUILD to linker 2d5f4cebdc configure: Use CFLAGS_FOR_BUILD when checking native compiler b408c6a8b2 Merge #579: Use __GNUC_PREREQ for detecting __builtin_expect 6198375218 Make randomization of a non-signing context a noop c663397f46 Use __GNUC_PREREQ for detecting __builtin_expect e34ceb333b Merge #557: Eliminate scratch memory used when generating contexts b3bf5f99a3 ecmult_impl: expand comment to explain how effective affine interacts with everything efa783f8f0 Store z-ratios in the 'x' coord they'll recover ffd3b346fe add `secp256k1_ge_set_all_gej_var` test which deals with many infinite points 84740acd2a ecmult_impl: save one fe_inv_var 47045270fa ecmult_impl: eliminate scratch memory used when generating context 7f7a2ed3a8 ecmult_gen_impl: eliminate scratch memory used when generating context 314a61d724 Merge #553: add static context object which has no capabilities 89a20a8945 Correct order of libs returned on pkg-config --libs --static libsecp256k1 call. 1086fda4c1 Merge #354: [ECDH API change] Support custom hash function d3cb1f95eb Make use of TAG_PUBKEY constants in secp256k1_eckey_pubkey_parse 40fde611bd prevent attempts to modify `secp256k1_context_no_precomp` ed7c08417a add static context object which has no capabilities 496c5b43b8 Make constants static: static const secp256k1_ge secp256k1_ge_const_g; static const int CURVE_B; bf8b86cc07 secp256k1_fe_sqrt: Verify that the arguments don't alias. 9bd89c836b Optimize secp256k1_fe_normalize_weak calls. Move secp256k1_fe_normalize_weak calls out of ECMULT_TABLE_GET_GE and ECMULT_TABLE_GET_GE_STORAGE and into secp256k1_ge_globalz_set_table_gej instead. 52ab96fedb clean dependendies in field_*_impl.h deff5edd42 Correct math typos in field_*.h 4efb3f8dd1 Add check that restrict pointers don't alias with all parameters. 1e6f1f5ad5 Merge #529: fix tests.c in the count == 0 case c8fbc3c397 [ECDH API change] Allow pass arbitrary data to hash function b00be65056 [ECDH API change] Support custom hash function 95e99f196f fix tests.c in the count == 0 case 452d8e4d2a Merge #523: scratch: add stack frame support 6fe50439ae scratch: add stack frame support 9bc2e26502 Merge #522: parameterize ecmult_const over input size 7c1b91ba4b parameterize ecmult_const over input size dbc3ddd5e2 Merge #513: Increase sparsity of pippenger fixed window naf representation 3965027c81 Summarize build options in configure script 0f0517369c Fix algorithm selection in bench_ecmult fb9271dcf0 Merge #510: add a couple missing `const`s to ecmult_pippenger_wnaf cd5f6028e5 Merge #515: Fix typo 09146ae854 Merge #512: secp256k1_ec_privkey_negate - fix documentation ec0a7b3ae3 Don't touch leading zeros in wnaf_fixed. 9e36d1bfe2 Fix bug in wnaf_fixed where the wnaf array is not completely zeroed when given a 0 scalar. 96f68a0afc Don't invert scalar in wnaf_fixed when it is even because a caller might intentionally give a scalar with many leading zeros. 8b3841c91d fix bug in fread() failure check cddef0c0be tests: add warning message when /dev/urandom fails 9b7c47a21e Fix typo 6dbb007869 Increase sparsity of pippenger fixed window naf representation 1646ace4d5 secp256k1_ec_privkey_negate - fix documentation 270f6c80db Portability fix for the configure scripts generated 9b3ff0309d add a couple missing `const`s to ecmult_pippenger_wnaf cd329dbc3e Merge #460: [build] Update ax_jni_include_dir.m4 macro 7f9c1a1565 Merge #498: tests: Avoid calling fclose(...) with an invalid argument f99aa8d4d3 Merge #499: tests: Make sure we get the requested number of bytes from /dev/urandom b549d3d5f7 Merge #472: [build] Set --enable-jni to no by default instead of auto. d333521516 Merge #494: Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS 2ef8ea5d21 Merge #495: Add bench_ecmult to .gitignore 82a96e4587 tests: Make sure we get the requested number of bytes from /dev/urandom 5aae5b5bb2 Avoid calling fclose(...) with an invalid argument cb32940df3 Add bench_ecmult to .gitignore 31abd3ab8d Support OpenSSL versions >= 1.1 for ENABLE_OPENSSL_TESTS c95f6f1360 Merge #487: fix tests typo, s/changed/unchanged fb46c83881 Merge #463: Reduce usage of hardcoded size constants 02f5001dfc Merge #490: Disambiguate bench functions and types 1f46d6089e Disambiguate bench functions and types f54c6c5083 Merge #480: Enable benchmark building by default c77fc08597 Merge #486: Add pippenger_wnaf for multi-multiplication d2f9c6b5dc Use more precise pippenger bucket windows 4c950bbeaf Save some additions per window in _pippenger_wnaf a58f543f5a Add flags for choosing algorithm in ecmult_multi benchmark 36b22c9337 Use scratch space dependent batching in ecmult_multi 355a38f113 Add pippenger_wnaf ecmult_multi bc65aa794e Add bench_ecmult dba5471b69 Add ecmult_multi tests 8c1c831bdb Generalize Strauss to support multiple points 548de42ecf add resizeable scratch space API 0e96cdc6b6 fix typo, s/changed/unchanged c7680e570f Reduce usage of hardcoded size constants 6ad5cdb42a Merge #479: Get rid of reserved _t in type names 7a78f60598 Print whether we're building benchmarks 4afec9f1ae Build benchmarks by default d1dc9dfc0a Get rid of reserved _t in type names 57752d28b3 [build] Set --enable-jni to no by default instead of auto. e7daa9b3c2 [build] Tweak JNI macro to warn instead of error for JNI not found. 5b22977922 [build] Update ax_jni_include_dir.m4 macro to deal with recent versions of macOS git-subtree-dir: src/secp256k1 git-subtree-split: b19c000063be11018b4d1a6b0a85871ab9d0bdcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up version of #503.