Use HMAC derivation for blinding keys #74
Conversation
sipa
force-pushed
the
deriveblind
branch
6 times, most recently
from
75f59f1 to
9610daf
Compare
|
Also included now:
|
sipa
force-pushed
the
deriveblind
branch
3 times, most recently
from
0e683da to
ef5696b
Compare
|
ACK when getaddressesbyaccount is fixed such that it includes blinding keys. |
|
Updated. |
| vBlindingKeys[nOut] = blinding_key.GetPubKey(); | ||
| } | ||
| } | ||
| if (!res && (blinding_key = pwallet->GetBlindingKey(NULL)).IsValid()) { |
There was a problem hiding this comment.
We're having issues with none of these three cases firing with either unblinded or static blinded outputs. We get:
alphad: base58.cpp:240: CBitcoinAddress& CBitcoinAddress::AddBlindingKey(const CPubKey&): Assertion `pubkey.size() == 33' failed.
There was a problem hiding this comment.
There was a problem hiding this comment.
It doesn't happen when the list is going to be empty.
There was a problem hiding this comment.
I pushed a fix for the non-blinded case.
|
My attempt at fixing sending, etc. |
|
@sipa Please review @instagibbs patch and add to your PR branch if you like it? |
|
@warren Cherry picked. |
c5904a9 Use HMAC derivation for blinding keys (Pieter Wuille)
Use a per-wallet secret to HMAC-SHA256 deriving blinding keys, rather than using a single static one.
No support for importing keys with alternate derivation keys yet.
Needs testing.